compaction now only identifies multi-value dimensions for dimension schemas which can possibly produce them#18760
Merged
clintropolis merged 3 commits intoDec 2, 2025
Conversation
…chemas which can possibly produce them changes: * added `DimensionSchema.canBeMultiValued`, defaulting to false but true for `StringDimensionSchema` and `NewSpatialDimensionSchema` * `CompactionTask.identifyMultiValuedDimensions` now checks `DimensionSchema.canBeMultiValued()` instead of checking for `ColumnType.STRING` from `DimensionSchema.getColumnType()` * added test to confirm behavior using `AutoTypeColumnSchema` with a specified `castToType` of `ColumnType.STRING`, which prior to changes would identify as multi-valued despite auto never producing them
gianm
approved these changes
Nov 19, 2025
| public abstract ColumnType getColumnType(); | ||
|
|
||
| @JsonIgnore | ||
| public boolean canBeMultiValued() |
Contributor
There was a problem hiding this comment.
Javadoc please. It always helps even for things that may be obvious to certain eyes.
kfaraz
approved these changes
Nov 20, 2025
| * <li> Range partitioning is done on a string dimension or an unknown dimension | ||
| * <li> Range partitioning is done on a possibly multi-valued string dimension or an unknown dimension | ||
| * (since MSQ does not support partitioning on a multi-valued string dimension) </li> | ||
| * <li> Rollup is done on a string dimension or an unknown dimension |
Contributor
There was a problem hiding this comment.
Suggested change
| * <li> Rollup is done on a string dimension or an unknown dimension | |
| * <li> Rollup is done on a possibly multi-valued string dimension or an unknown dimension |
Contributor
|
IT failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes:
DimensionSchema.canBeMultiValued(), defaulting to false but true forStringDimensionSchemaandNewSpatialDimensionSchemaCompactionTask.identifyMultiValuedDimensionsnow checksDimensionSchema.canBeMultiValued()instead of checking forColumnType.STRINGfromDimensionSchema.getColumnType()AutoTypeColumnSchemawith a specifiedcastToTypeofColumnType.STRING, which prior to changes would identify as multi-valued despite auto never producing them