prometheus-emitter: disable label tracking when the TTL isn't set#18718
Conversation
| public void resetLastUpdateTime(List<String> labelValues) | ||
| { | ||
| if (ttlSeconds == null) { | ||
| // Label tracking is only required if a metric TTL has been configured |
There was a problem hiding this comment.
Could move this comment to the method's javadoc
|
The failing embedded |
|
@abhishekrb19 , even though the primary failure was unrelated, we should probably try re-runs in this case as there might be some ITs/docker tests that use the prometheus emitter (I don't know if there any though) and may be affected by the changes in the PR. On that note, I think we should try adding an embedded test for the Prometheus emitter. |
|
The failure seems to have been due to a race condition in the auth embedded test. |
Ah yes, sorry, I should've clarified, the CI was retried and it failed twice in a row before merging (and I recall seeing the same failure on another PR too). |
Thanks for the clarification! Yes, embedded tests have been acting out a little recently as we migrate more and more to them. I think they may have stumbled upon some race conditions in the Overlord code. I plan to spend some time investigating it next week. |
…ache#18718) Follow up to apache#18689 to not track labels if the TTL isn't set Co-authored-by: Andrew Ho <[email protected]>
4 participants
A small follow up to #18689 to not track labels if the TTL isn't set
Key changed/added classes in this PR
DimensionsAndCollectorPrometheusEmitterTestThis PR has: