Skip to content

fix(kubernetes-overlord-extensions): implement streamTaskReports in K…#18711

Merged
FrankChen021 merged 2 commits into
apache:masterfrom
keoliva:stream-task-reports-k8sAndWorker-runner
Nov 6, 2025
Merged

fix(kubernetes-overlord-extensions): implement streamTaskReports in K…#18711
FrankChen021 merged 2 commits into
apache:masterfrom
keoliva:stream-task-reports-k8sAndWorker-runner

Conversation

@keoliva

@keoliva keoliva commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

…ubernetesAndWorkerTaskRunner

Description

Fixed a bug where progress details were missing when using druid.indexer.runner.type=k8sAndWorker. We kept seeing “Loading…” in the Druid Console instead of the view we’re used to seeing.
image

After overriding KubernetesAndWorkerTaskRunner's implementation of streamTaskReports, progress details now show correctly, whether druid.indexer.runner.k8sAndWorker.runnerStrategy.type is set to k8s or worker.

Release note

Fix an issue where ingestion task progress was not displayed in the Druid Console when running in migration mode (druid.indexer.runner.type=k8sAndWorker) for MM-less Druid.


Key changed/added classes in this PR
  • KubernetesAndWorkerTaskRunner

This PR has:

  • been self-reviewed.(Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…ubernetesAndWorkerTaskRunner

Progress details were missing when using druid.indexer.runner.type=k8sAndWorker.

Implement streamTaskReports to delegate to kubernetesTaskRunner first, then fall back to workerTaskRunner if it implements TaskLogStreamer.

Progress details now show correctly when druid.indexer.runner.k8sAndWorker.runnerStrategy.type={k8s,worker}.
@keoliva
keoliva marked this pull request as draft November 3, 2025 19:57

@kfaraz kfaraz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution, @keoliva !

@keoliva
keoliva marked this pull request as ready for review November 4, 2025 05:28
@FrankChen021
FrankChen021 merged commit 9106cb0 into apache:master Nov 6, 2025
37 checks passed
@keoliva
keoliva deleted the stream-task-reports-k8sAndWorker-runner branch November 6, 2025 08:36
@kgyrtkirk kgyrtkirk added this to the 36.0.0 milestone Jan 19, 2026
riovic918data pushed a commit to riovic918data/druid that referenced this pull request Jun 12, 2026
apache#18711)

* fix(kubernetes-overlord-extensions): implement streamTaskReports in KubernetesAndWorkerTaskRunner

Progress details were missing when using druid.indexer.runner.type=k8sAndWorker.

Implement streamTaskReports to delegate to kubernetesTaskRunner first, then fall back to workerTaskRunner if it implements TaskLogStreamer.

Progress details now show correctly when druid.indexer.runner.k8sAndWorker.runnerStrategy.type={k8s,worker}.

* add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants