Skip to content

Remove various version overrides from module poms.#18708

Merged
gianm merged 9 commits into
apache:masterfrom
gianm:mvn-versions
Nov 20, 2025
Merged

Remove various version overrides from module poms.#18708
gianm merged 9 commits into
apache:masterfrom
gianm:mvn-versions

Conversation

@gianm

@gianm gianm commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Many poms explicitly specified versions for dependencies and plugins that have centrally-managed versions in the master pom's dependencyManagement and pluginManagement section.

For the most part, the overrides were simply restating the centrally-managed version, so they weren't causing an actual divergence. In these cases, removing the overrides simply improves maintainability by promoting the usages of dependencyManagement and pluginManagement.

The most substantive change is that hamcrest is upgraded from 1.3 to 2.2. Version 2.2 was already being used by kubernetes-overlord-extensions.

@github-actions github-actions Bot added Area - Batch Ingestion Area - Querying Area - Metrics/Event Emitting Area - Streaming Ingestion Area - Lookups Area - Dependencies Kubernetes Area - Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 31, 2025
Many poms explicitly specified versions for dependencies and plugins
that have centrally-managed versions in the master pom's dependencyManagement
and pluginManagement section.

For the most part, the overrides were simply restating the centrally-managed
version, so they weren't causing an actual divergence.

The most substantive change is that hamcrest is upgraded from 1.3 to 2.2.
Version 2.2 was already being used by kubernetes-overlord-extensions.
@jtuglu1

jtuglu1 commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

I wonder if there's a way to do this with Druid versions too? Instead of stating 36.0.0-SNAPSHOT everywhere, just define it once in the root pom?

@kfaraz kfaraz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, @gianm !
Should we also consider adding a checkstyle rule that ensures that future PRs do not add explicit versions?

@kfaraz

kfaraz commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

I wonder if there's a way to do this with Druid versions too? Instead of stating 36.0.0-SNAPSHOT everywhere, just define it once in the root pom?

yeah, that would be nice too.

@gianm

gianm commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

I wonder if there's a way to do this with Druid versions too? Instead of stating 36.0.0-SNAPSHOT everywhere, just define it once in the root pom?

I'm not sure if there's a way to do that while still preserving maven's ability to do release:prepare and release:perform. It has some automation for updating all of these versions in multi-module projects.

Should we also consider adding a checkstyle rule that ensures that future PRs do not add explicit versions?

I actually wanted to do this but wasn't sure how, so I skipped it. Do you happen to know how to implement a check like this for pom.xml?

@gianm
gianm merged commit 0ee6855 into apache:master Nov 20, 2025
57 checks passed
@gianm
gianm deleted the mvn-versions branch November 20, 2025 23:55
@kgyrtkirk kgyrtkirk added this to the 36.0.0 milestone Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - Dependencies Area - Ingestion Area - Lookups Area - Metrics/Event Emitting Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying Area - Streaming Ingestion Kubernetes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants