add SegmentFileBuilder, SegmentFileMapper, SegmentFileChannel interfaces#18608
Merged
Conversation
…ces to abstract segment building and reading implementations
gianm
approved these changes
Oct 13, 2025
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…ces (apache#18608) * add SegmentFileBuilder, SegmentFileMapper, SegmentFileChannel interfaces to abstract segment building and reading implementations * unused import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new interfaces for segment file building and mapping to replace direct usages of
FileSmoosherandSmooshedFileMapper, allowing for additional implementations to be defined.Release note
(for developers)
New
SegmentFileBuilderandSegmentFileMapperinterfaces have been defined to replace direct usages ofFileSmoosherandSmooshedFileMapperto abstract the segment building and reading process.The main developer visible changes for extension writers with custom column implementations is that the
Serializerinterface has changed thewriteTomethod, which now accepts aSegmentFileBuilderinstead of aFileSmoosher, and theColumnBuildermethodgetFileMappernow returns aSegmentFileMapperinstead ofSmooshedFileMapper. Extensions which do not provide custom column implementations should not be impacted by these changes.