Add ARRAY query parameter support in workbench view#18586
Merged
Conversation
Contributor
|
You want to run |
Contributor
|
From the failing test: Fix this by running |
Contributor
|
I think you need to update the snapshots. Try |
Contributor
Author
I believe I did in the previous commit named update test snapshot |
Contributor
Author
|
Looks like the unit tests fail for a reason unrelated to the PR, do you think a rebase/merge with main is necessary here @vogievetsky |
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* Add ARRAY query parameter supprot in workbench view * Update druid-query-toolkit to 1.2.1 * Update licenses * Update axios license * prettify * update test snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support in the web console for providing arrays (i.e
ARRAYtype) dynamic parameters in the workbench -> parameters dialog view when executing SQL queries.This PR depends on druid-query-toolkit/pull/105 which makes the
QueryParameter.valueproperty support arrays.Screen.Recording.-.480p.mov
Release note
New: You can now define ARRAY type parameters in the query console.
Key changed/added classes in this PR
query-parameters-dialog.tsxThis PR has: