Refactor segmentLocalCacheManager#18494
Merged
FrankChen021 merged 3 commits intoOct 22, 2025
Merged
Conversation
7 tasks
Contributor
Author
|
Hi @kfaraz, can you take a look at this, and highlight any concerns, so that further change requests to #18489 is easier for your review when I'm back from my break? FYI: #18489 (comment) |
FrankChen021
approved these changes
Oct 22, 2025
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
* Refactor segmentLocalCacheManager * Try catch for addFilesToCachedSegments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor SegmentLocalCacheManager
Refactor
getCachedSegments()by extracting 2 functions:retrieveSegmentMetadataFiles()addFilesToCachedSegments()Added AtomicInteger to pass by reference and count
ignorednumber of files.This PR is created to ensure changes in #18489 are easier to review.
Release note
Key changed/added classes in this PR
SegmentLocalCacheManager.javaThis PR has: