Skip to content

feat: add count of merge buffers per groupby query metrics#17945

Closed
TessaIO wants to merge 1 commit into
apache:masterfrom
TessaIO:feat-add-merge-buffers-per-query-metrics
Closed

feat: add count of merge buffers per groupby query metrics#17945
TessaIO wants to merge 1 commit into
apache:masterfrom
TessaIO:feat-add-merge-buffers-per-query-metrics

Conversation

@TessaIO

@TessaIO TessaIO commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #17944.

Description

Add mergeBuffer/usedCount metric per query for the used merge buffers. This metric is different from mergeBuffer/used because that one is a point-in-time metric, and this one is for each query. It's also different from mergeBuffer/queries because that metric gets incremented for each query but it only gets incremented by one, whereas some queries can reserve more than 1 merge buffer.

Release note

Add mergeBuffer/usedCount metric per query for the used merge buffers

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@TessaIO
TessaIO force-pushed the feat-add-merge-buffers-per-query-metrics branch 2 times, most recently from 5a67c5c to d1dbfd6 Compare April 23, 2025 17:32
@TessaIO
TessaIO force-pushed the feat-add-merge-buffers-per-query-metrics branch 3 times, most recently from 8864a04 to 79e6da2 Compare April 23, 2025 17:49
@TessaIO
TessaIO force-pushed the feat-add-merge-buffers-per-query-metrics branch from 79e6da2 to c228f11 Compare April 23, 2025 18:29
@TessaIO
TessaIO marked this pull request as ready for review April 23, 2025 19:35
@TessaIO

TessaIO commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

@LakshSingla @gianm how can I run a local cluster to test the changes?

@kfaraz

kfaraz commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

@TessaIO , you can try following the steps here Druid Local Quickstart

@github-actions

github-actions Bot commented Jun 29, 2025

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the [email protected] list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Jun 29, 2025
@TessaIO

TessaIO commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

/remove stale

@github-actions github-actions Bot removed the stale label Jul 2, 2025
@github-actions

github-actions Bot commented Aug 31, 2025

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the [email protected] list.
Thank you for your contributions.

@github-actions github-actions Bot added the stale label Aug 31, 2025
@github-actions

github-actions Bot commented Sep 28, 2025

Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions Bot closed this Sep 28, 2025
@abhishekrb19

abhishekrb19 commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

@TessaIO are you interested in getting this change in with some testing? I can help review the change when it's ready. Thanks!

@GWphua GWphua mentioned this pull request Nov 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area - Documentation stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add metric for the number of merge buffers per query

3 participants

@TessaIO @kfaraz @abhishekrb19