Add new context parameter for using concurrent locks#15684
Merged
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
kfaraz
reviewed
Jan 15, 2024
kfaraz
left a comment
kfaraz
left a comment
Contributor
There was a problem hiding this comment.
Changes look good, left a minor comment.
Also, there seem to be some coverage issues. Maybe add a couple more tests for the new context parameter.
Contributor
|
Merging as failure is unrelated. |
AmatyaAvadhanula
added a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Jan 29, 2024
Changes: - Add new task context flag useConcurrentLocks. - This can be set for an individual task or at a cluster level using `druid.indexer.task.default.context`. - When set to true, any appending task would use an APPEND lock and any other ingestion task would use a REPLACE lock when using time chunk locking. - If false (default), we fall back on the context flag taskLockType and then useSharedLock.
LakshSingla
pushed a commit
that referenced
this pull request
Jan 30, 2024
Changes: - Add new task context flag useConcurrentLocks. - This can be set for an individual task or at a cluster level using `druid.indexer.task.default.context`. - When set to true, any appending task would use an APPEND lock and any other ingestion task would use a REPLACE lock when using time chunk locking. - If false (default), we fall back on the context flag taskLockType and then useSharedLock.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
Changes: - Add new task context flag useConcurrentLocks. - This can be set for an individual task or at a cluster level using `druid.indexer.task.default.context`. - When set to true, any appending task would use an APPEND lock and any other ingestion task would use a REPLACE lock when using time chunk locking. - If false (default), we fall back on the context flag taskLockType and then useSharedLock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new task context flag
useConcurrentLocks.This can be set for an individual task or at a cluster level using
druid.indexer.task.default.context.When set to true any appending task would use an APPEND lock and any other ingestion task would use a REPLACE lock when using time chunk locking.
If not, we fall back on the context flag
taskLockTypeand thenuseSharedLock.This PR has: