Revert issue with lifecycle change in mmless ingestion#15346
Merged
Conversation
…pache#15133)" This reverts commit dc0b163.
cryptoe
approved these changes
Nov 8, 2023
cryptoe
left a comment
cryptoe
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the revert. I believe the logic after this revert is correct.
Reporting the Kubernetes job runtime as the task duration makes more sense since I am assuming that will account for cleanup of the pod as well.
Also when people compare the job runtime across Kubernetes UI and web-console, they should see the same runtime of the job/task.
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
…pache#15133)" (apache#15346) This reverts commit dc0b163.
FrankChen021
pushed a commit
that referenced
this pull request
Feb 3, 2025
GabrielCWT
pushed a commit
to GabrielCWT/druid
that referenced
this pull request
Sep 9, 2025
…pache#15133)" (apache#15346) This reverts commit dc0b163.
riovic918data
pushed a commit
to riovic918data/druid
that referenced
this pull request
Jun 12, 2026
…pache#15133)" (apache#15346) This reverts commit dc0b163.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dc0b163.
The change updates TaskStatus to be reported by the abstract task instead of the overlord, the abstract task does not properly report duration and it is always reported as -1.
Key changed/added classes in this PR
AbstractTaskKubernetesTaskRunnerKubernetesPeonLifecycleThis PR has: