Skip to content

Draft to ensure top level filters use 2 valued logic#14949

Closed
kgyrtkirk wants to merge 25 commits into
apache:masterfrom
kgyrtkirk:inc-results-neq
Closed

Draft to ensure top level filters use 2 valued logic#14949
kgyrtkirk wants to merge 25 commits into
apache:masterfrom
kgyrtkirk:inc-results-neq

Conversation

@kgyrtkirk

Copy link
Copy Markdown
Member

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

RexBuilder rexBuilder = partialQuery.getRelBuilder().getRexBuilder();
RexExecutor executor = partialQuery.getRelBuilder().getCluster().getPlanner().getExecutor();

RexSimplify rs = new RexSimplify(rexBuilder, false, executor);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [RexSimplify.RexSimplify](1) should be avoided because it has been deprecated.
RexSimplify rs = new RexSimplify(rexBuilder, false, executor);
RexNode w = rexBuilder.makeCall(SqlStdOperatorTable.IS_TRUE, partialQuery.getWhereFilter().getCondition());
// : rexBuilder.makeCall(SqlStdOperatorTable.IS_NOT_FALSE, e);
RexNode w2 = rs.simplify(w);

Check notice

Code scanning / CodeQL

Unread local variable

Variable 'RexNode w2' is never read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants