Skip to content

Conversation

@matiasbertani
Copy link
Contributor

@matiasbertani matiasbertani commented Dec 2, 2025

Without it eks or gke versions will not be considered as valid versions

Related to #401

What problem does this PR solve?

Helm relies on Masterminds/semver for version comparison. According to both the Helm docs and the SemVer README (see the "Checking Version Constraints" section), version ranges do not match pre-release versions unless the constraint explicitly allows them.

EKS (and GKE) Kubernetes versions always include a pre-release suffix, e.g.: v1.34.1-eks-3025e55. So, with a constraint like >= 1.19, SemVer will not consider pre-release versions valid, so Helm rejects the chart even though the Kubernetes version is technically higher.

The SemVer documentation explains that to include pre-releases in a version range, you must add a -0 suffix: >= 1.19.0-0

After changing the chart’s kubeVersion to include .0-0, Helm correctly accepted the EKS version.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Without this, eks or gke versions will not be considered
as valid versions
@matiasbertani
Copy link
Contributor Author

Hi @catpineapple, sorry to bother you. I saw that you reviewed and merged the previous PRs related to the helm-charts dir. Could you please check this one ?

@catpineapple
Copy link
Contributor

Thank you very much for your submission. This is a thoughtful change. Will this change affect operation on self-built or open-source Kubernetes? Have you conducted any related tests?

@matiasbertani
Copy link
Contributor Author

@catpineapple thanks for the quick response.

Will this change affect operation on self-built or open-source Kubernetes? Have you conducted any related tests?

This change does not affect any operation neither in self-built or kubernetes. It is only a fix in the kuberentes version constraint (the kubeVersion field at Chart.yaml) at the moment of installing the chart.

Ref: https://helm.sh/docs/v3/topics/charts/#the-kubeversion-field

@tomasmiguez
Copy link

We are being affected by this same issue.

@matiasbertani
Copy link
Contributor Author

friendly ping @catpineapple

@matiasbertani
Copy link
Contributor Author

desperate ping @catpineapple

@catpineapple catpineapple merged commit bb44910 into apache:master Dec 11, 2025
1 check passed
@sivakumar07
Copy link

@catpineapple @matiasbertani When are you planned to give this in chart release. Last release happen on sep. Can you do one release to solve this?

@catpineapple catpineapple mentioned this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants