Skip to content

Conversation

@matiasbertani
Copy link
Contributor

@matiasbertani matiasbertani commented Dec 2, 2025

What problem does this PR solve?

Add support to setup resources in the dosris-operator helm chart.

Problem Summary:

The chart exposes resources configuration fields in values.yaml under dorisOperator.resources, but the Deployment template always used the "hard-coded" default values instead of the user-provided overrides.

This issue can be reproduced as follows:

ᐅ  helm template doris-operator ./doris-operator \
--set dorisOperator.resources.requests.memory=50Mi \
--set dorisOperator.resources.requests.cpu=200m \
| yq 'select(.kind == "Deployment") .spec.template.spec.containers[0].resources'

requests:
  cpu: 2
  memory: 4Gi
limits:
  cpu: 2
  memory: 4Gi

The values coming from values.yaml are ignored, and the Deployment always renders the default resources.

After applying the template changes included in this PR, Helm correctly renders the user-configured resources:

ᐅ  helm template doris-operator ./doris-operator \
--set dorisOperator.resources.requests.memory=50Mi \
--set dorisOperator.resources.requests.cpu=200m \   
| yq 'select(.kind == "Deployment") .spec.template.spec.containers[0].resources'

requests:
  cpu: 200m
  memory: 50Mi

This confirms that the chart now properly respects user-defined resource settings from values.yaml

Release note

Add support to setup resources in the dosris-operator helm chart.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@matiasbertani
Copy link
Contributor Author

@catpineapple a couple of eyes in this PR will be appreciated too. Thanks!

@matiasbertani
Copy link
Contributor Author

friendly ping @catpineapple

@matiasbertani
Copy link
Contributor Author

desperate ping @catpineapple

@catpineapple catpineapple merged commit 3237e79 into apache:master Dec 11, 2025
1 check passed
@catpineapple catpineapple mentioned this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants