Skip to content

[Enhancement][helm] helm release version use variable for replace #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
catpineapple merged 2 commits into from
Mar 7, 2025
Merged

[Enhancement][helm] helm release version use variable for replace #354

catpineapple merged 2 commits into from
Mar 7, 2025

Conversation

@intelligentfu8
Copy link
Contributor

@intelligentfu8 intelligentfu8 commented Mar 6, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@catpineapple catpineapple merged commit 09286bf into apache:master Mar 7, 2025
1 check passed
@intelligentfu8 intelligentfu8 mentioned this pull request Mar 12, 2025
Closed
@xiacongling
Copy link
Contributor

xiacongling commented Mar 13, 2025 •
edited
Loading

@intelligentfu8 with this patch, the chart cannot installed with default settings, like

helm install doris-operator helm-charts/doris-operator

could your provide the doc about how to install the helm chart? the current README should be updated to match the code.

@intelligentfu8
Copy link
Contributor Author

intelligentfu8 commented Mar 13, 2025

@xiacongling https://artifacthub.io/packages/helm/doris/doris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catpineapple catpineapple catpineapple approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@intelligentfu8 @xiacongling @catpineapple