Repository navigation
[fix] (planner) passthrough child in SetOperationNode is wrong when enable vectorized engine - #9991
Merged
Merged
Conversation
…nable vector engine
github-actions
Bot
added
the
area/planner
morrySnow
added
area/planner
dataroaring
approved these changes
Jun 7, 2022
dataroaring
left a comment
dataroaring
left a comment
Contributor
There was a problem hiding this comment.
I tested it, and it pass the failed case.
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
pushed a commit
that referenced
this pull request
Jun 8, 2022
…able vector engine (#9991) In SetOperationNode we do passthrough, if we child output is same with itself output. In method isChildPassthrough we only consider memory layout. When we use vectorized engine, we need to use SlotDesc offset in TupleDesc instead of memory layout to check whether pass-through can be performed
morningman
added
dev/merged-1.0.1-deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9952
Problem Summary:
In SetOperationNode we do passthrough, if we child output is same with itself output. In method
isChildPassthroughwe only consider memory layout. When we use vectorized engine, we need to use SlotDesc offset in TupleDesc instead of memory layout to check whether pass-through can be performedChecklist(Required)
Further comments
Add UT and regression-test later.