Skip to content

[fix] (planner) slot nullable does not set correctly when plan outer join with inline view - #9927

Merged
morningman merged 5 commits into
apache:masterfrom
morrySnow:fix_outer_join_nullable
Jun 3, 2022
Merged

[fix] (planner) slot nullable does not set correctly when plan outer join with inline view#9927
morningman merged 5 commits into
apache:masterfrom
morrySnow:fix_outer_join_nullable

Conversation

@morrySnow

@morrySnow morrySnow commented Jun 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close #9925

  • set inline view's slot descriptor to nullable in register column ref
  • propagate slot nullable when generate inline view's query node in SingleNodePlanner

Problem Summary:

When plan left outer join, we need to set all SlotDescriptor at right hand to nullable. But under some case, it is not happen anymore.

Detail could be found in related issue #9925

Checklist(Required)

  1. Does it affect the original behavior: Yes
  2. Has unit tests been added: No
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

@github-actions github-actions Bot added area/planner Issues or PRs related to the query planner kind/test labels Jun 1, 2022
@morningman morningman added the dev/1.0.1-deprecated should be merged into dev-1.0.1 branch label Jun 1, 2022
@morningman morningman added this to the v1.1 milestone Jun 1, 2022
@morrySnow morrySnow changed the title [fix] (planner) slot nullable is not set correctly when plan outer join with inline view [fix] (planner) slot nullable does not set correctly when plan outer join with inline view Jun 2, 2022
morningman
morningman approved these changes Jun 2, 2022
View reviewed changes

@morningman morningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 2, 2022
@github-actions

github-actions Bot commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 3031919 into apache:master Jun 3, 2022
@morningman morningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Jun 3, 2022
morningman pushed a commit that referenced this pull request Jun 3, 2022
@morrySnow @morningman
[fix] (planner) slot nullable does not set correctly when plan outer …
fd2375a 
…join with inline view (#9927)

- set inline view's slot descriptor to nullable in register column ref
- propagate slot nullable when generate inline view's query node in SingleNodePlanner
@dataroaring dataroaring mentioned this pull request Jun 4, 2022
Closed
2 of 3 tasks
@morrySnow
morrySnow deleted the fix_outer_join_nullable branch June 8, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 kind/test reviewed

Projects

None yet

Milestone

v1.1

Development

Successfully merging this pull request may close these issues.

[Bug] (planner) SlotDescriptor set as 'is not null' at right hand in left outer join

2 participants

@morrySnow @morningman