Repository navigation
handle ComlumnDictionary in evaluate_and and evaluate_or - #9818
Merged
Merged
Conversation
We need to handle ComlumnDictory in evaluate_or, otherwise delete handler would triger a core dump.
Because there is only one difference between evaluate_and and evaluate_or, that is or and delete, I merge two macros into one. Delete handlers also trigger evaluate_and, i am not sure if column dictionary would be used in evaluate_and.
dataroaring
added
the
dev/1.0.1-deprecated
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added
dev/merged-1.0.1-deprecated
morningman
added a commit
that referenced
this pull request
Jun 1, 2022
* handle ColumnDictory in evaluate_or We need to handle ComlumnDictory in evaluate_or, otherwise delete handler would triger a core dump. * handle ComlumnDictionary in evaluate_and Because there is only one difference between evaluate_and and evaluate_or, that is or and delete, I merge two macros into one. Delete handlers also trigger evaluate_and, i am not sure if column dictionary would be used in evaluate_and. * clang format * fix short circut for evaluate_and and evaluate_or * clang format
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jun 22, 2026
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9823
Problem Summary:
Be core dump when handle delete predicates on key.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...