Repository navigation
[BUG][Vectorized] fix replace_if_not_null in vectorized compaction - #9376
Merged
Merged
Conversation
BiteTheDDDDt
reviewed
May 5, 2022
morningman
added
area/compact
HappenLee
reviewed
May 6, 2022
| _default_value.reset(); | ||
| _is_init = false; | ||
| _has_value = false; | ||
| if constexpr (init_with_null) { |
Contributor
There was a problem hiding this comment.
the logic only use in child class， should not do in parent.
github-actions
Bot
added
the
kind/docs
Gabriel39
force-pushed
the
fix_vectorized_compaction
branch
from
May 6, 2022 04:32
2492b15 to
6a94c6e
Compare
Gabriel39
force-pushed
the
fix_vectorized_compaction
branch
from
May 6, 2022 04:36
6a94c6e to
7555453
Compare
HappenLee
reviewed
May 6, 2022
| this->set_null_if_need(); | ||
| frame_start = std::max<int64_t>(frame_start, partition_start); | ||
| frame_end = std::min<int64_t>(frame_end, partition_end); | ||
| if (const auto* nullable_column = check_and_get_column<ColumnNullable>(columns[0])) { |
Contributor
There was a problem hiding this comment.
use if constexpr to speed up the function
Gabriel39
force-pushed
the
fix_vectorized_compaction
branch
from
May 6, 2022 06:04
2986b57 to
f80150d
Compare
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
Bot
removed
the
approved
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9374
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...