Repository navigation
[Bug] (fix) DeltaWriter::mem_consumption() coredump - #9245
Merged
Merged
Conversation
chenlinzhong
changed the title
chenlinzhong
changed the title
yiguolei
reviewed
Apr 27, 2022
| // Sort the DeltaWriters by mem consumption in descend order. | ||
| std::vector<DeltaWriter*> writers; | ||
| for (auto& it : _tablet_writers) { | ||
| it.second->save_mem_consumption_snapshot(); |
Contributor
Author
There was a problem hiding this comment.
What's the core reason?
mem_consumption() returned value may be changed during sort period for same element, this does not meet comp requirements
Contributor
|
why the case normal in old code? |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
morningman
added
dev/1.0.1-deprecated
github-actions
Bot
removed
the
approved
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
mem_consumption() returned value may be changed during sort period for same element, this does not meet comp requirements
mem_consumption() returned value may be changed during sort period for same element, this does not meet comp requirements
mem_consumption() returned value may be changed during sort period for same element, this does not meet comp requirements
github-actions
Bot
removed
the
approved
morningman
approved these changes
May 7, 2022
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
morningman
added
dev/merged-1.0.1-deprecated
morningman
pushed a commit
that referenced
this pull request
May 15, 2022
starocean999
pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
englefly
pushed a commit
to englefly/incubator-doris
that referenced
this pull request
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: open #9237
Problem Summary:
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...