Repository navigation
[Vectorized][Function] support function stddev/variance/stddev_samp/variance_samp - #7734
Merged
Merged
Conversation
zhangstar333
changed the title
HappenLee
reviewed
Jan 13, 2022
| } | ||
|
|
||
| void register_alias(const std::string& name, const std::string& alias, bool nullable = false) { | ||
| if(nullable) { |
Contributor
There was a problem hiding this comment.
change to like alias function
|
|
||
| template <typename T, bool is_stddev> | ||
| struct BaseData { | ||
| using ColVecType = std::conditional_t<IsDecimalNumber<T>, ColumnDecimal<Decimal128>, ColumnVector<T>>; |
zhangstar333
force-pushed
the
stddev_vec
branch
from
January 13, 2022 12:11
ec9c69c to
9aab10e
Compare
HappenLee
pushed a commit
that referenced
this pull request
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7733
Problem Summary:
Describe the overview of changes.
Checklist(Requried)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...