Repository navigation
[Vectorized][Bug] fix get wrong result when select random column && fix get wrong has_null_tag - #7728
Merged
Merged
Conversation
Contributor
|
the same issue occurred to me LGTM |
zuochunwei
reviewed
Jan 12, 2022
| for (auto idx : _agg_columns_idx) { | ||
| FieldAggregationMethod agg_method = tablet_schema.column(idx).aggregation(); | ||
| FieldAggregationMethod agg_method = | ||
| tablet_schema.column(_real_columns_idx[idx]).aggregation(); |
Contributor
There was a problem hiding this comment.
_real_columns_idx[idx]
can be replaced by
read_params.origin_return_columns->at(_return_columns_loc[idx])
Contributor
Author
There was a problem hiding this comment.
Okay,I modified this.
BiteTheDDDDt
changed the title
Contributor
|
LGTM |
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 13, 2022
…ix get wrong has_null_tag (apache#7728)
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 13, 2022
…ix get wrong has_null_tag (apache#7728)
HappenLee
pushed a commit
that referenced
this pull request
Jan 17, 2022
…ix get wrong has_null_tag (#7728)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #7727
Problem Summary:
Describe the overview of changes.
Checklist(Requried)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...