Repository navigation
[Vectorized][Feature] support money_format/ucase/character_length - #7649
Merged
Merged
Conversation
zuochunwei
reviewed
Jan 7, 2022
| auto data_column = assert_cast<const ColumnVector<Float64>*>(argument_column.get()); | ||
| auto result_column = assert_cast<ColumnString*>(res_column.get()); | ||
|
|
||
| for (int i = 0; i < input_rows_count; i++) { |
| static DataTypes get_variadic_argument_types() { return {std::make_shared<DataTypeInt64>()}; } | ||
|
|
||
| static Status execute_impl(FunctionContext* context, Block& block, | ||
| const ColumnNumbers& arguments, size_t result, |
Contributor
There was a problem hiding this comment.
these execute_impl versions just have a little different.
suggest you to design a common function reducing code lines?
Contributor
Author
There was a problem hiding this comment.
these execute_impl versions just have a little different. suggest you to design a common function reducing code lines?
I do some improve.
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 13, 2022
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Jan 13, 2022
HappenLee
pushed a commit
that referenced
this pull request
Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Close related #7648 (replace it with issue number if it exists).
@HappenLee
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...