Skip to content

[Vectorized][Feature] fix core dump when using function override and function alias at the same time && support substr(str,int) override - #7640

Merged
HappenLee merged 2 commits into
apache:vectorizedfrom
BiteTheDDDDt:dev_sub
Jan 6, 2022
Merged

HappenLee merged 2 commits into
apache:vectorizedfrom
BiteTheDDDDt:dev_sub

Conversation

@BiteTheDDDDt

@BiteTheDDDDt BiteTheDDDDt commented Jan 6, 2022 •

Copy link
Copy Markdown
Contributor

Proposed changes

Close related #7639 (replace it with issue number if it exists).

@HappenLee @zbtzbtzbt

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

…same time && support substr(str,int) override
@BiteTheDDDDt BiteTheDDDDt changed the title [Feature] fix core dump when using function override and function alias at the same time && support substr(str,int) override [Vectorized][Feature] fix core dump when using function override and function alias at the same time && support substr(str,int) override Jan 6, 2022
Comment thread be/src/vec/functions/function_string.h Outdated
return get_variadic_argument_types_impl().size();
}

bool is_variadic() const override { return true; }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you set get_number_of_arguments(), is_variadic() is false. we should check the number of argument

@HappenLee
HappenLee merged commit 5830710 into apache:vectorized Jan 6, 2022
@zbtzbtzbt

Copy link
Copy Markdown
Contributor

good job

HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
…function alias at the same time && support substr(str,int) override (apache#7640)
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
…function alias at the same time && support substr(str,int) override (apache#7640)
HappenLee pushed a commit that referenced this pull request Jan 17, 2022
…function alias at the same time && support substr(str,int) override (#7640)
@BiteTheDDDDt
BiteTheDDDDt deleted the dev_sub branch January 20, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants