Skip to content

[vectorized] [block] add new method get_data_type to avoid unnecessary copy by the method get_data_type - #7600

Merged
HappenLee merged 2 commits into
apache:vectorizedfrom
zuochunwei:blockRefactor
Jan 7, 2022
Merged

HappenLee merged 2 commits into
apache:vectorizedfrom
zuochunwei:blockRefactor

Conversation

@zuochunwei

@zuochunwei zuochunwei commented Jan 4, 2022 •

Copy link
Copy Markdown
Contributor

Proposed changes

  1. add new method get_data_type for class Block to reduce the copy cost of get_data_types
  2. change function erase_useless_column()'s loop control variable i to type int for safety reason

Close related #issue (replace it with issue number if it exists).

Describe the overview of changes, and introduce why we need it.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [ x] Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@zuochunwei zuochunwei changed the title [vectorized] [block] add new method get_data_type to avoid get_data_types unnecessary coping [vectorized] [block] add new method get_data_type to avoid get_data_types unnecessary copy Jan 4, 2022
@zuochunwei zuochunwei changed the title [vectorized] [block] add new method get_data_type to avoid get_data_types unnecessary copy [vectorized] [block] add new method get_data_type to avoid unnecessary copy by the method get_data_type Jan 4, 2022
@wangbo wangbo self-assigned this Jan 5, 2022

@wangbo wangbo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2022
@github-actions

github-actions Bot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei

yiguolei commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

perfectly

Comment thread be/src/vec/core/block.h Resolved
@HappenLee
HappenLee merged commit 4ec9f0c into apache:vectorized Jan 7, 2022
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
…y copy by the method get_data_type (apache#7600)

Co-authored-by: zuochunwei <[email protected]>
HappenLee pushed a commit to HappenLee/incubator-doris that referenced this pull request Jan 13, 2022
…y copy by the method get_data_type (apache#7600)

Co-authored-by: zuochunwei <[email protected]>
HappenLee pushed a commit that referenced this pull request Jan 17, 2022
…y copy by the method get_data_type (#7600)

Co-authored-by: zuochunwei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants