Repository navigation
branch-4.2: [fix](variant) Read exact sparse cells during path promotion - #70356
Merged
yiguolei merged 8 commits intoNov 10, 2026
Merged
Conversation
Member
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run cloud_p0 |
…tests On branch-4.x, casting Variant(max_subcolumns=0) from parse_to_variant into a column typed Variant(max_subcolumns=1) is rejected. Insert JSON strings instead so the cast uses the target column type, keeping the compaction sparse-ancestor promotion coverage from apache#70212.
Member
Author
|
run buildall |
Same branch-4.x Variant→Variant cast rejection as the literal inserts.
Member
Author
|
run buildall |
…anch-4.x branch-4.x CAST(variant_string AS STRING) returns JSON-quoted "text", while the cherry-picked master .out expected unquoted text. NonConcurrent sparse_ancestor_promotion_extended failed qt_before on that cell.
Member
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
… bool/[] On branch-4.x, CAST(bool AS STRING) yields true/false while CAST(variant AS STRING) serializes bool as 1/0; empty array sparse values are omitted.
Member
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run cloud_p0 |
…on on branch-4.x Before compaction, CAST(v AS STRING) still shows "a":1; after vertical compaction promotes the typed path, branch-4.x serializes the bool as true. Align promoted/repromoted .out accordingly.
Member
Author
|
run buildall |
Member
Author
|
run buildall |
Member
Author
|
run cloud_p0 |
Member
Author
|
run nonConcurrent |
Member
Author
|
run cloud_p0 |
Member
Author
|
run external |
Member
Author
|
run cloud_p0 |
Member
Author
|
run external |
Member
Author
|
run cloud_p0 |
Member
Author
|
run external |
yiguolei
approved these changes
Nov 10, 2026
Contributor
|
skip buildall |
yiguolei
approved these changes
Nov 10, 2026
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #70212
Conflicts resolved: kept branch-4.2 exact-match _fill_variant_v2_path (already equivalent; dual V1/V2 API) and added intent comment. Adapted new BE UTs to branch APIs (ColumnVariant::create_binary_column_fn / StorageReadOptions.stats / use_variant_v2=true). BE UT left to CI (branch-4.2 full UT build known lance_reader issue); same adaptations validated via branch-4.1 UT run.