Repository navigation
branch-4.2: [fix](cloud) Skip global packed index probe when opening files of committed rowsets #69980 - #70235
Merged
Merged
Conversation
…mitted rowsets (#69980) ### What problem does this PR solve? Issue Number: None Related PR: #64995 Problem Summary: A cloud BE logs a burst of WARN lines with a full stack trace like meet error status: [NOT_FOUND]File not found in global packed index: data/<tablet>/<rowset>_0.idx while compaction reads its input rowsets. In one instance a 4-hour BE log had 42k such lines over 21k paths in 158 tablets, yet every compaction succeeded. Reproduce: write a rowset whose segment file is smaller than small_file_threshold_bytes (so it is packed) but whose inverted index file is larger (so it is uploaded as a regular object), then compact or query it. Each open of the regular .idx file prints the WARN with a stack, twice per compaction (eligibility check and the merge itself). Root cause: #64995 made PackedFileSystem::open_file_impl fall back to PackedFileManager::get_packed_slice_location when a path is not in _index_map, so that the file cache preload can read back a segment of the rowset being written, whose rowset meta does not exist yet. The fallback was added unconditionally, so it also runs for a PackedFileSystem built from a rowset meta. That index map already holds every packed slice of the rowset, so a miss means a regular file, and the probe can only fail. The failure is a Status::NotFound, and NOT_FOUND records a stack trace and logs a WARN as soon as it is constructed, before the caller falls back to opening the regular file. Fix: - Only consult the manager when the index map is not initialized, i.e. on the write path, the same split exists_impl and file_size_impl already make. - Return NOT_FOUND without a stack trace from get_packed_slice_location: on the write path a miss is also expected, for files too large to be packed. After the fix, reading committed rowsets no longer takes the global index lock or logs anything for regular files; the write-path preload still finds packed slices through the manager. ### Release note Fix noisy "File not found in global packed index" WARN logs with stack traces when reading rowsets that mix packed and regular files in cloud mode.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Nov 6, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #69980