Repository navigation
branch-4.2: [fix](packed-file) Honor write_file_cache option for packed small files #69693 - #70114
Merged
Merged
Conversation
…es (apache#69693) Issue Number: None Related PR: apache#59892, apache#60411, apache#64995 Problem Summary: When packed file is enabled, the first segment file (`.dat`) and the index file (`.idx`) of a rowset are written through `PackedFileSystem`. The packed path decides whether to cache each small file from `PackedAppendContext::write_file_cache`, which defaults to `true`. `RowsetWriterContext` never sets this field. (cherry picked from commit bf58c2c) Backport to branch-4.2: resolve the test insertion conflict without bringing in the unrelated nonzero-first-segment test, whose feature is absent on this branch. Validation: clang-format 16 and git diff --check passed. BE UT could not start because the local Xcode license has not been accepted.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #69693
Problem Summary:
Backport #69693 to
branch-4.2.With packed files enabled, a load using
disable_file_cache=truecould still populate the file cache because the packed writer ignored the caller's option. Always propagateFileWriterOptions::write_file_cacheto the packed append context.The test insertion conflict was resolved without importing the unrelated nonzero-first-segment feature/test, which is absent on this branch. Includes the cache-option unit test and preserves the original accessor cleanup.
Release note
Fix packed-file loads with
disable_file_cache=trueunexpectedly populating the file cache.Check List (For Author)
git diff --checkpassed. BE unit tests are included but were not run locally: the test entry point was blocked by the Mac's unaccepted Xcode license. CIrun buildallis requested separately after PR creation.