Repository navigation
branch-4.2: [fix](rbo) Preserve semantics in predicate inference #67919 - #70080
Merged
Merged
Conversation
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve? Related PR: apache#67919 Problem Summary: 不等式关系被误记为等式，且等值替换跨越不保值的类型或表示 Backport adaptation: Preserve existing index-dependent MATCH/multi_match/SEARCH exclusions and date-arithmetic pushdown protection while adding non-movable expression guards and injective cast checks. Keep all branch tests alongside the upstream test additions. Include only the common ExpressionTrait non-movable/volatile predicate helper from prerequisite apache#67067; retain its type-bitset fast path and conditional volatile semantics. Rebase adjustment: Rebase onto branch-4.2 after apache#67653 merged. Keep the generalized isInjectiveCastTo check, which includes DATETIMEV2 precision-loss rejection, and preserve the merged precision regression tests. ### Release note 不等式关系被误记为等式，且等值替换跨越不保值的类型或表示 ### Check List (For Author) - Test: Unit Test — org.apache.doris.nereids.rules.rewrite.InferPredicateByReplaceTest,org.apache.doris.nereids.rules.rewrite.UnequalPredicateInferTest,org.apache.doris.nereids.types.DataTypeTest,org.apache.doris.nereids.util.ExpressionUtilsTraversalTest,org.apache.doris.nereids.util.ExpressionUtilsTest; FE Checkstyle passed. Cluster regression tests were not run for this commit. - Behavior changed: Yes, fixes the behavior described above. - Does this need documentation: No (cherry picked from commit 5f107ef)
Contributor
Author
|
run buildall |
morrySnow
force-pushed
the
codex/branch-4.2-pick-67919
branch
from
November 3, 2026 12:12
e6898b1 to
92639e4
Compare
Contributor
FE UT Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picked from master #67919