Skip to content

branch-4.2: [fix](agg) Normalize equivalent multi-column distinct counts #65206 - #70043

Merged
yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-65206
Nov 3, 2026
Merged

branch-4.2: [fix](agg) Normalize equivalent multi-column distinct counts #65206#70043
yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-65206

Conversation

@morrySnow

@morrySnow morrySnow commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

picked from master #65206

@feiniaofeiafei @morrySnow
[fix](agg) Normalize equivalent multi-column distinct counts
c228f87 
### What problem does this PR solve?

Related PR: apache#65206

Problem Summary: 多列 COUNT DISTINCT 的等价重排/重复参数没有归一，可能选错策略或越界

Backport adaptation: Keep the target-branch removal of PushDownAggWithDistinctThroughJoinOneSide; backport normalization, CountIf argument handling and tests.

### Release note

多列 COUNT DISTINCT 的等价重排/重复参数没有归一，可能选错策略或越界

### Check List (For Author)

- Test: Unit Test — org.apache.doris.nereids.rules.analysis.NormalizeMultiColumnDistinctCountTest; FE Checkstyle passed. Cluster regression tests were not run for this commit.
- Behavior changed: Yes, fixes the behavior described above.
- Does this need documentation: No

(cherry picked from commit d921beb)
@morrySnow

morrySnow commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow
morrySnow requested a review from yiguolei as a code owner November 3, 2026 05:29
@hello-stephen

hello-stephen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (20/20) 🎉
Increment coverage report
Complete coverage report

@yiguolei

yiguolei commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei
yiguolei merged commit 8e76d76 into apache:branch-4.2 Nov 3, 2026
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @hello-stephen @yiguolei @feiniaofeiafei