Skip to content

branch-4.2: [fix](nereids) Do not turn invalid UTF-8 from BE constant folding into U+FFFD #69143 - #70024

Merged
yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-69143
Nov 3, 2026
Merged

yiguolei merged 1 commit into
apache:branch-4.2from
morrySnow:codex/branch-4.2-pick-69143

Conversation

@morrySnow

Copy link
Copy Markdown
Contributor

picked from master #69143

…o U+FFFD

### What problem does this PR solve?

Related PR: apache#69143

Problem Summary: BE 折叠返回非法 UTF-8 时 FE 静默替换成 U+FFFD,改变值

Backport adaptation: Keep source and expected results unchanged; place the regression suite under branch-4.2 nereids_p0/expression/fold_constant after its directory rename. Replace Java 17 HexFormat in tests with the existing Guava BaseEncoding API because the branch compiles against Java 11 APIs.

### Release note

BE 折叠返回非法 UTF-8 时 FE 静默替换成 U+FFFD,改变值

### Check List (For Author)

- Test: Unit Test — org.apache.doris.nereids.trees.expressions.LiteralTest; FE Checkstyle passed. Cluster regression tests were not run for this commit.
- Behavior changed: Yes, fixes the behavior described above.
- Does this need documentation: No

(cherry picked from commit 6c27d4d)
@morrySnow

Copy link
Copy Markdown
Contributor Author

run buildall

@morrySnow
morrySnow requested a review from yiguolei as a code owner November 3, 2026 04:21
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉
Increment coverage report
Complete coverage report

@yiguolei
yiguolei merged commit f7bbac6 into apache:branch-4.2 Nov 3, 2026
28 of 30 checks passed
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants