Repository navigation
branch-4.2: [fix](constant folding) Reject overflowing from_second and from_millisecond literals #67037 - #70014
Merged
Conversation
…second literals ### What problem does this PR solve? Related PR: apache#67037 Problem Summary: from_second/from_millisecond 常量折叠对溢出输入生成错误日期 Backport adaptation: Keep branch-4.2 timestampNsDiff alongside the new checked-multiplication helper; preserve the original overflow and range tests. ### Release note from_second/from_millisecond 常量折叠对溢出输入生成错误日期 ### Check List (For Author) - Test: Unit Test — org.apache.doris.nereids.trees.expressions.functions.executable.DateTimeExtractAndTransformTest; FE Checkstyle passed. Cluster regression tests were not run for this commit. - Behavior changed: Yes, fixes the behavior described above. - Does this need documentation: No (cherry picked from commit e7fd245)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
|
skip buildall |
yiguolei
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picked from master #67037