Repository navigation
[improvement](be) Let each SNII index spend a size budget on faster .prx windows - #69769
Conversation
…prx windows ### What problem does this PR solve? Issue Number: None Related PR: apache#69649 Problem Summary: apache#69649 stores a .prx window as PFOR instead of zstd when zstd saves less than snii_prx_zstd_min_saving_percent (30) of the PFOR frame, because every read of a zstd window pays a decompression. What that costs and buys depends on how much zstd saves on the data. Replaying the 1.6M windows of 10M AgentLogs rows, 30 spends 8% more bytes on the windows zstd compresses and cuts their decode time by 42%; on the windows of TextBench service logs it spends 5% and cuts 6%; on data whose windows zstd shrinks by just under 30% it stores every window as PFOR. No single percentage fits all data. Each index of a segment now spends a size budget instead: PrxZstdBudget, owned by its LogicalIndexWriter and reached through PrxWindowLimits, so the resident and the spilled encoder, and the ordinary and the compaction build, all use it. A window whose smallest frame is zstd is stored in its faster frame (PFOR, or raw when smaller) when - its saving is below the share whose trades, over the windows the index has seen, fit 8% of their smallest frames, which puts the budget on the windows zstd shrinks least, and - the bytes the index has actually traded, this window included, still fit 8% of the smallest frames seen. This makes 8% a bound for any order of windows: fed the TextBench windows from the largest saving to the smallest, the share alone spends 36%. Until it has seen 64 windows the share is 30, the previous default. The choice uses the frames the writer builds anyway: nothing is compressed twice or scanned ahead, and the same input gives the same bytes. snii_prx_zstd_min_saving_percent now defaults to -1 (the budget); 0-100 keeps a fixed share, 0 the smallest frame. The budget is 8% rather than less: with it the AgentLogs phrase queries below read nearly the same frames as with 30, while in the replay a 5% budget cuts the decode time by 31% instead of 39%. 10M rows each, same binary, one stream load per table, size against the smallest frames (0): - AgentLogs: index +4.59% with 30, +3.37% with the budget (table +2.13%, +1.57%). The phrase queries read the same frames: all PFOR for DS1, DS2, DS6, DS7, A6 and A9 with both, and 326 against 324 zstd frames of 5011 for DS4, 1049 against 1041 of 25930 for A10. - TextBench: index +0.89% with 30, +0.79% with the budget (table +0.51%, +0.45%). Most windows stay zstd either way (P1 'connection reset': 582 against 583 zstd frames of 599). - Data bytes are identical; the index written with 0 and with 30 is byte-for-byte the size the previous binary writes. - Hot queries, budget data against 30 data in one process (6-10 paired cycles, ratio of medians per cycle): all 25 AgentLogs and 15 TextBench queries 0.96-1.04, the same results. - Write cost: the choice adds about 48 ns per window, 79 ms over the 1.6M AgentLogs windows. ### Release note SNII now chooses per index how many position windows to store in the faster but larger PFOR form, spending at most 8% of their size; snii_prx_zstd_min_saving_percent defaults to -1 for this, and 0-100 still sets a fixed percentage. ### Check List (For Author) - Test: Unit Test (SniiPrxZstdBudget: the prior share, the windows zstd shrinks least traded first, the bound under a descending order, windows with nothing to trade; SniiPrxPodTest: the faster frame and when the budget is asked; SniiStreamedWriterSessionTest: windows that save 1-29% through the ordinary and the streamed build, where 30 trades all of them and the budget at most 8%; SniiWriterPrxZstdSaving: the default and the config mapping). Manual test: index size of 10M-row AgentLogs and TextBench loads with 0, 30 and the budget, frames read per codec from query profiles. - Behavior changed: Yes (the default .prx codec choice of newly written segments; existing segments are read as before) - Does this need documentation: No Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
/review |
There was a problem hiding this comment.
Reviewed all 11 changed files at head 170822d, including ordinary/streamed builds and resident/replayable encoding. One P2 finding: successful fast-path windows are omitted from the per-index budget, so later windows can retain zstd despite available space for faster frames. No existing inline findings or additional user-provided focus were supplied.
Critical checkpoints:
- Goal and proof: the per-index adaptive policy and fixed-percentage override are implemented, with one incomplete accounting path described inline. Added tests exercise the budget and both writer modes, but omit mixed short-window/compressible-window accounting.
- Scope and clarity: changes are focused on codec policy, ownership/config propagation, and unit coverage; existing codec selection and serialization are reused.
- Concurrency and locks: each index owns its mutable budget. Production flush and merge paths feed one writer serially; no new threads, shared global budget, lock acquisitions, or lock-order changes were introduced.
- Lifecycle and initialization: heap-owned LogicalIndexWriter instances remain at stable addresses; synchronous encoders borrow their budget through copied limits. Moving owning unique_ptrs does not move the writer. Constants are constexpr, with no new cross-translation-unit initialization dependency.
- Configuration: the existing mutable setting now defaults to -1; negative values enable the budget, and 0-100 preserve fixed mode. Both direct-load and compaction resolve it for each new index; already-started writers retain their resolved policy.
- Compatibility: codec IDs, frame layouts, lengths, CRCs, and reader allocation guards are unchanged. Budget state is writer-only; existing readers support every selected codec. No new libc APIs or build/link dependencies were introduced; no ELF/runtime validation was performed.
- Thrift/protobuf: no gensrc changes.
- Parallel paths: ordinary and streamed writes share process_term and the same budget owner; resident and replayable encoders reach the new chooser. Both also contain the fast-path accounting omission covered by the single inline finding.
- Conditional checks: warmup, histogram eligibility, spend limits, and reader-safe frame alternatives have concrete comments and defined states. Split validation occurs before budget mutation.
- Test coverage: inspected the added warmup, least-saving preference, descending-order cap, no-trade credit, raw/PFOR/readability, config mapping, and ordinary/streamed size tests, plus adjacent round-trip, spill and failure coverage. The no-trade test calls add() directly and cannot detect the production omission. No builds, tests, or benchmarks were run under this static-only contract.
- Test results: added expected values and size inequalities are consistent with the code by inspection; no generated regression-output files changed. Runtime results remain unverified.
- Observability: existing per-codec decode counters/timing and framing errors remain available; no separate observability defect was established.
- Transactions and persistence: transaction versions, delete bitmaps, EditLog/replay, and FE failover protocols are unchanged. Existing index serialization is reused.
- Writes and failure atomicity: unsuccessful split attempts do not credit or spend budget. Errors after a choice poison the enclosing logical/compound writer, preventing reuse of abandoned accounting or sealing of partial output.
- FE/BE propagation: no new transmitted variables or protocol fields.
- Performance and memory: one fixed 101-bucket histogram per index; bounded scans and arithmetic use already-built frame sizes, with no second compression or added payload allocation. The inline finding concerns missed opportunities for faster reads; no claim of size-cap violation or wrong query results is made.
- Other concerns: no additional verified correctness, error-propagation, include-hygiene, or ownership issue. Every initial risk was resolved to the accepted omission or dismissed with call-chain evidence.
Coverage limits: static source and test inspection only; compression timings, benchmark claims, final ELF ABI, and runtime spill equivalence were not executed or measured.
Review converged after 2 round(s).
| const AutoPrxCodecChoice choice = select_auto_prx_codec( | ||
| payload.size(), plain.size(), compressed.size(), has_compressed, | ||
| limits.max_uncomp_bytes, limits.zstd_min_saving_percent); | ||
| const AutoPrxCodecChoice choice = choose_auto_prx_codec( |
There was a problem hiding this comment.
[P2] Credit fast-path windows to the per-index budget
The new budget only sees windows that reach choose_auto_prx_codec, but this builder emits singleton RAW and sub-512-byte PFOR windows without reaching that call; choose_position_codec has the same bypasses in the replayable path. Their committed frames therefore supply neither budget bytes nor warmup observations, so indexes with many short posting lists unnecessarily keep later windows as zstd even when their faster frames fit the 8% index budget. For example, 64 singleton {7} frames contribute 576 bytes; for the 900-byte zstd / 1000-byte PFOR choice used in the new selector test, those bytes raise the allowance from 72 to 118, enough for the 100-byte trade, but the current writer ignores them. Record each successfully emitted fast-path frame with PrxZstdBudget::add in both encoders, and cover a short-window prefix followed by compressible windows through the writer rather than only calling add directly.
There was a problem hiding this comment.
This is deliberate; c360054 makes it explicit in the class comment and the config comment.
The budget is a share of the windows that get a zstd frame (a plain payload of at least 512 bytes), the only ones whose codec a share decides. Singleton and short windows are never traded, so they are left out of both the allowance and the warmup:
- Counting their bytes would make the allowance for the large windows grow with the number of short posting lists an index has: in an index of many rare terms, its large windows could grow by well over 8% of their own size. The sizes in the description (the budget below the fixed 30 on every dataset measured) use this definition.
- Counting them toward the warmup, as
add()does, would end the prior share before any tradable window is seen. The share computed from an empty histogram is 100, so the first large windows would then be traded whatever their saving until the cap stops it.
So the 8% is a share of the windows the policy acts on, the stricter of the two readings.
…share of The budget is a share of the smallest frames of the windows that get a zstd frame, the only ones whose codec a share decides; windows written without one (a singleton, or too short to compress) are not counted. Comments only. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
run buildall |
|
/review |
There was a problem hiding this comment.
No new actionable findings at c360054eeea27241056d8ab256e1d487b7d611dc. Reviewed all 11 changed files and the production load/rebuild and streamed-compaction chains, including resident and replayable position encoding. The review converged in 1 round: both complete-review scopes and the separate risk-focused investigation returned NO_NEW_VALUABLE_FINDINGS, and every candidate and initial risk has an evidence-backed disposition.
The existing short-window thread was revalidated against the author reply and current class/config comments. Excluding singleton and short windows from both allowance and warmup matches the explicitly defined eligible-window budget, so that concern is not repeated. There are no existing P0/P1 findings to carry forward. No additional user focus was supplied.
| Required checkpoint | Conclusion |
|---|---|
| Goal and supporting tests | The shared chooser implements the per-index size budget using complete frames and an independent cumulative-byte admission check. Added unit tests express warmup, histogram selection, byte-bound, readability and configuration expectations; the session test covers ordinary and streamed output. |
| Scope and reuse | The change is focused on write-policy selection, configuration capture and tests, reusing the existing codec selector and framing. |
| Concurrency and locks | Budget state belongs to one sequential logical-index writer. Ordinary iteration and compaction pushes consume terms synchronously; no new shared global state, thread, lock or lock-order edge was found. |
| Lifecycle and static initialization | Limits borrow a writer-owned inline budget. Production moves heap ownership through unique_ptr without moving the writer object, preserving its address. No ownership cycle or cross-translation-unit initialization dependency is introduced. |
| Configuration | The existing mutable setting now defaults to -1. Negative selects the budget; nonnegative values retain the fixed percentage and existing clamping. New index creation captures current policy without requiring restart. |
| Storage/API compatibility | RAW/PFOR/ZSTD codec IDs, framing, CRCs and reader guards are unchanged. The budget is writer-only; existing readers consume the selected existing frame formats. |
| Thrift/protobuf IDs | No generated protocol definitions or numeric IDs change. |
| Parallel paths | Production ordinary/direct-load/rebuild and streamed compaction use the shared resolver. Resident and replayable encoders both forward the owned budget to the shared chooser. |
| Conditional branches | Readability gates and strict minimum-frame comparisons make the size differences nonnegative; unreadable PFOR is not selected as a faster alternative. The documented short-window bypasses match across encoders. |
| Test coverage | Inspected all changed tests and their setup/cleanup. The new session test exercises resident encoding; no new test explicitly forces spilling with the budget enabled. The replayable branch and its propagation were reviewed directly. |
| Expected test results | Added frame-size arithmetic and inequalities match the implementation by inspection. Existing golden digests are preserved; no regression output files change. No test execution is claimed. |
| Observability | Codec identity remains persisted in frame headers and existing status/reader checks remain available. No new distributed operation or error mode requiring separate tracing was found. |
| Transactions and persistence | Only codec choice changes. Selected codecs persist in existing frames; EditLog, failover, visible-version and delete-bitmap behavior are untouched. |
| Writes, errors and crash handling | Split requests occur before budget mutation. Successfully built inline/windowed frames are copied or streamed unchanged. Later codec, allocation or I/O failures poison the writer/container and prevent sealing or successful reuse of partial state. |
| FE/BE variables | No transmitted variable or FE send path is added; this is a BE-local write policy. |
| Performance and memory | The inline histogram has fixed size and scans at most 100 bins per eligible observation after warmup. Already-built candidates are reused; there is no added compression pass, full-index buffering or posting rescan. Performance measurements were not reproduced. |
| Other module checkpoints | No new PCH/hub-header dependency, template-instantiation family, source-cpp test inclusion, CLucene boundary or glibc API/toolchain change was found. No additional actionable defect remained after the final sweep. |
Static review only: no builds, test runs, benchmarks, source modifications or submodule initialization were performed. Runtime behavior, forced-spill budget execution and built-artifact compatibility remain outside this review's validation. These limits are distinct from review convergence; all assigned static scopes and candidate dispositions are complete.
Review converged after 1 round(s).
TPC-H: Total hot run time: 28633 ms |
TPC-DS: Total hot run time: 151186 ms |
ClickBench: Total hot run time: 24.39 s |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
### What problem does this PR solve? Issue Number: None Related PR: #69649, #69769 Problem Summary: A phrase query decodes the positions of the selected documents of every .prx window it reads. Timed per window on a 10M-row AgentLogs load, a zstd window cost 18.6 us against 1.4 us for a PFOR window: 11.7 us to decode the plain payload, 4.8 us to decompress, and about 2 us more because every window created and freed its own zstd context (about 96 KB) and a zero-filled output vector. Two commits: 1. **Decode the plain payload without a Status per document.** `decode_payload_csr_selective` made at least one out-of-line call returning a Status for every document of the window, selected or not (`get_varint32_fast`, `skip_varints`, `decode_delta_run`). The loop now keeps the cursor in a register and handles the usual cases inline: a single-byte count, walking past the deltas of a document that is not selected, and a run of single-byte deltas. Anything else -- a multi-byte value, a run that does not fit, a prefix sum that would overflow -- goes to the checked decoders from the same cursor, so they decide and report as before. The output vector grows as before; nothing is reserved up front. 2. **Reuse one zstd context and buffer per index source.** `ZstdDecompressor` keeps one context, created at the first zstd frame, and one output buffer that only grows and is not zero-filled (decompression writes every byte before it is read). The buffer comes from the Doris allocator (`DorisUniqueBufferPtr`), so the decoding task's memory tracker accounts for it while it is held. `SniiIndexSource` owns one, and the cursors it opens pass it to the .prx decoder through `PrxDecodeContext`. The cursors of a source decode on its thread one window at a time, and the decoded payload is consumed before the next window is read. A source lives for one query on one segment, so a query holds at most one context and one buffer per segment it reads, and only if it decodes a zstd window; before, each window created and released them. Compaction decodes through an allocation gate, which keeps the old path, as does a cursor given no decompressor. Hot queries, old against new read path in one process (run-time switch in an experiment build, 6 paired cycles), on 99M AgentLogs rows written with the smallest frames, as every segment written before #69649 is (mostly zstd windows): DS7 (unfiltered phrase) 0.87x, A6 0.89x, A10 0.93x, DS4 (phrase prefix) 0.94x, A9 0.95x, DS1 0.96x; repeating the old path against itself gave 0.93-1.05. The gain follows the zstd windows a query reads: the phrase queries of AgentLogs written with #69649 read PFOR windows and do not change, and on TextBench, whose large windows stay zstd, the time per window is the decompression itself and the change is within noise. Every query returns the same result. ### Release note None
### What problem does this PR solve? Issue Number: None Related PR: #69649, #69769 Problem Summary: A phrase query decodes the positions of the selected documents of every .prx window it reads. Timed per window on a 10M-row AgentLogs load, a zstd window cost 18.6 us against 1.4 us for a PFOR window: 11.7 us to decode the plain payload, 4.8 us to decompress, and about 2 us more because every window created and freed its own zstd context (about 96 KB) and a zero-filled output vector. Two commits: 1. **Decode the plain payload without a Status per document.** `decode_payload_csr_selective` made at least one out-of-line call returning a Status for every document of the window, selected or not (`get_varint32_fast`, `skip_varints`, `decode_delta_run`). The loop now keeps the cursor in a register and handles the usual cases inline: a single-byte count, walking past the deltas of a document that is not selected, and a run of single-byte deltas. Anything else -- a multi-byte value, a run that does not fit, a prefix sum that would overflow -- goes to the checked decoders from the same cursor, so they decide and report as before. The output vector grows as before; nothing is reserved up front. 2. **Reuse one zstd context and buffer per index source.** `ZstdDecompressor` keeps one context, created at the first zstd frame, and one output buffer that only grows and is not zero-filled (decompression writes every byte before it is read). The buffer comes from the Doris allocator (`DorisUniqueBufferPtr`), so the decoding task's memory tracker accounts for it while it is held. `SniiIndexSource` owns one, and the cursors it opens pass it to the .prx decoder through `PrxDecodeContext`. The cursors of a source decode on its thread one window at a time, and the decoded payload is consumed before the next window is read. A source lives for one query on one segment, so a query holds at most one context and one buffer per segment it reads, and only if it decodes a zstd window; before, each window created and released them. Compaction decodes through an allocation gate, which keeps the old path, as does a cursor given no decompressor. Hot queries, old against new read path in one process (run-time switch in an experiment build, 6 paired cycles), on 99M AgentLogs rows written with the smallest frames, as every segment written before #69649 is (mostly zstd windows): DS7 (unfiltered phrase) 0.87x, A6 0.89x, A10 0.93x, DS4 (phrase prefix) 0.94x, A9 0.95x, DS1 0.96x; repeating the old path against itself gave 0.93-1.05. The gain follows the zstd windows a query reads: the phrase queries of AgentLogs written with #69649 read PFOR windows and do not change, and on TextBench, whose large windows stay zstd, the time per window is the decompression itself and the change is within noise. Every query returns the same result. ### Release note None
… on faster .prx windows #69769 (#69796) ### What problem does this PR solve? Issue Number: None Related PR: #69769, #69649 (backport #69795), #69770 (backport #69788) Problem Summary: Backport of #69769 to branch-4.2, stacked on #69795 (the backport of #69649). #69649 stores a .prx window as PFOR instead of zstd when zstd saves less than `snii_prx_zstd_min_saving_percent` (30) of the PFOR frame, because every read of a zstd window pays a decompression. What that costs and buys depends on how much zstd saves on the data. Replaying the 1.6M windows of 10M AgentLogs rows, 30 spends 8% more bytes on the windows zstd compresses and cuts their decode time by 42%; on the windows of TextBench service logs it spends 5% and cuts 6%; on data whose windows zstd shrinks by just under 30% it stores every window as PFOR. No single percentage fits all data. Each index of a segment now spends a size budget instead: `PrxZstdBudget`, owned by its `LogicalIndexWriter` and reached through `PrxWindowLimits`, so the resident and the spilled encoder, and the ordinary and the compaction build, all use it. A window whose smallest frame is zstd is stored in its faster frame (PFOR, or raw when smaller) when - its saving is below the share whose trades, over the windows the index has seen, fit 8% of their smallest frames, which puts the budget on the windows zstd shrinks least, and - the bytes the index has actually traded, this window included, still fit 8% of the smallest frames seen. This makes 8% a bound for any order of windows: fed the TextBench windows from the largest saving to the smallest, the share alone spends 36%. Until it has seen 64 windows the share is 30, the previous default. The windows counted are those that get a zstd frame (a plain payload of at least 512 bytes), the only ones whose codec a share decides; singleton and short windows are written as before and counted neither in the allowance nor in the warmup. The choice uses the frames the writer builds anyway: nothing is compressed twice or scanned ahead, and the same input gives the same bytes. `snii_prx_zstd_min_saving_percent` now defaults to -1 (the budget); 0-100 keeps a fixed share, 0 the smallest frame. The budget is 8% rather than less: with it the AgentLogs phrase queries below read nearly the same frames as with 30, while in the replay a 5% budget cuts the decode time by 31% instead of 39%. Same binary, one stream load per table, size against the smallest frames (0): | data | index, 30 | index, budget | table, 30 | table, budget | |---|---|---|---|---| | AgentLogs 99M rows | +4.13% | +3.65% | +1.92% | +1.69% | | AgentLogs 10M rows | +4.59% | +3.37% | +2.13% | +1.57% | | TextBench 12M rows | +0.89% | +0.79% | +0.51% | +0.45% | - The phrase queries read the same frames with 30 and with the budget: at 99M rows all PFOR for DS1, DS6, DS7, A6 and A9 (for example 107,307 frames for DS7), and about 11,170 zstd frames of about 259,000 for A10 with both; on TextBench most windows stay zstd either way (582 against 583 zstd frames of 599 for 'connection reset'). - Hot queries in one process, budget data against 30 data with the same read path (paired cycles: 6 for the 25 AgentLogs queries at 10M rows, 10 for the 15 TextBench queries): 0.96-1.06 and 0.97-1.05; every query returns the same result. - Against the data written before #69649 (smallest frames), the 11 AgentLogs phrase queries at 99M rows take 0.83x in geometric mean with the budget data (DS7 0.63x, A6 0.67x, A9 0.70x, DS4 0.74x, A10 0.77x), as with 30 (0.83x). This run also had the read-path change of #69770, which does not touch the PFOR windows these queries read. - Data bytes are identical, and the index written with 0 and with 30 has exactly the size the previous binary writes. - Write cost: the choice adds about 48 ns per window, 79 ms over the 1.6M AgentLogs windows. ### Branch adaptations None. `git cherry-pick 0571eb6` applied cleanly on top of the backport of #69649, which it needs: it changes the setting #69649 adds, and the automatic pick to branch-4.2 failed because branch-4.2 does not have #69649. This PR is stacked on that backport, #69795, so it shows both commits until #69795 merges; merge #69795 first. ### Validation - Built and run with both backports (this one and the stacked #69769 backport) applied to branch-4.2 at 711db43, the commit before #69625: its lance-c update is not in the local third-party build, and the 16 commits after it touch no SNII file. `PrxPod*`, `Snii*`, `DorisSniiFileReader*`, `*InvertedIndex*`, `*IndexFileWriter*` and `*IndexFileReader*`: 1710 tests passed, including the new budget, codec choice, writer and configuration tests. - On master both changes passed CI. - Not built locally on the branch-4.2 tip; this PR's BE UT run covers that. ### Release note SNII now chooses per index how many position windows to store in the faster but larger PFOR form, spending at most 8% of the size of the windows zstd compresses; `snii_prx_zstd_min_saving_percent` defaults to -1 for this, and 0-100 still sets a fixed percentage. ### Check List (For Author) - Test: Unit Test - SniiPrxZstdBudget: the prior share, the windows zstd shrinks least are traded first, the bound under a descending order, windows with nothing to trade. - SniiPrxPodTest: the faster frame (PFOR or raw) and when the budget is asked. - SniiStreamedWriterSessionTest: windows that save 1-29% through the ordinary and the streamed (compaction) build; 30 trades all of them, the budget at most 8% of the smallest frames. - SniiWriterPrxZstdSaving: the default and the config mapping. - Manual test: index size of 10M and 99M AgentLogs and 12M TextBench loads with 0, 30 and the budget; frames read per codec from query profiles; interleaved hot A/B in one process. - Behavior changed: Yes (the default .prx codec choice of newly written segments; existing segments are read as before) - Does this need documentation: No 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: martin.foo838 <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
What problem does this PR solve?
Issue Number: None
Related PR: #69649, #69770
Problem Summary: #69649 stores a .prx window as PFOR instead of zstd when zstd saves less than
snii_prx_zstd_min_saving_percent(30) of the PFOR frame, because every read of a zstd window pays a decompression. What that costs and buys depends on how much zstd saves on the data. Replaying the 1.6M windows of 10M AgentLogs rows, 30 spends 8% more bytes on the windows zstd compresses and cuts their decode time by 42%; on the windows of TextBench service logs it spends 5% and cuts 6%; on data whose windows zstd shrinks by just under 30% it stores every window as PFOR. No single percentage fits all data.Each index of a segment now spends a size budget instead:
PrxZstdBudget, owned by itsLogicalIndexWriterand reached throughPrxWindowLimits, so the resident and the spilled encoder, and the ordinary and the compaction build, all use it. A window whose smallest frame is zstd is stored in its faster frame (PFOR, or raw when smaller) whenUntil it has seen 64 windows the share is 30, the previous default. The windows counted are those that get a zstd frame (a plain payload of at least 512 bytes), the only ones whose codec a share decides; singleton and short windows are written as before and counted neither in the allowance nor in the warmup. The choice uses the frames the writer builds anyway: nothing is compressed twice or scanned ahead, and the same input gives the same bytes.
snii_prx_zstd_min_saving_percentnow defaults to -1 (the budget); 0-100 keeps a fixed share, 0 the smallest frame.The budget is 8% rather than less: with it the AgentLogs phrase queries below read nearly the same frames as with 30, while in the replay a 5% budget cuts the decode time by 31% instead of 39%.
Same binary, one stream load per table, size against the smallest frames (0):
Release note
SNII now chooses per index how many position windows to store in the faster but larger PFOR form, spending at most 8% of the size of the windows zstd compresses;
snii_prx_zstd_min_saving_percentdefaults to -1 for this, and 0-100 still sets a fixed percentage.Check List (For Author)
🤖 Generated with Claude Code