Skip to content

[test](regression) Rename the binlog result tags left in the cloud changelog suites - #69374

Merged
morningman merged 1 commit into
apache:masterfrom
morningman:changelog-t12-cloud-tags
Oct 22, 2026
Merged

morningman merged 1 commit into
apache:masterfrom
morningman:changelog-t12-cloud-tags

Conversation

@morningman

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: #69311

Problem Summary: #69311 renamed row binlog to changelog. It also renamed the result tags that said binlog in the changelog suites and regenerated their .out files, except in the two suites that only run in cloud mode, test_cloud_changelog_compaction and test_cloud_changelog_publish_conflict: regenerating their .out files needs a cloud cluster running that code. Those two suites still carry nine tags that say binlog, such as qt_row_binlog_publish_conflict and order_qt_cloud_dup_binlog_compaction.

This renames the nine tags in the two groovy files and the matching "-- !tag --" lines in the two .out files, the same way #69311 renamed the tags of the other changelog suites (row_binlog -> changelog, binlog_compaction -> changelog_compaction). The queries are unchanged, so no result row changes. The .out files were edited by hand, only on the nine tag lines, instead of being regenerated.

Release note

None

Check List (For Author)

  • Test: No need to test. Only result tag names change; the queries and the expected rows are unchanged. The two suites return early outside cloud mode and were not run locally.
  • Behavior changed: No
  • Does this need documentation: No

…angelog suites

### What problem does this PR solve?

Issue Number: None

Related PR: apache#69311

Problem Summary: apache#69311 renamed row binlog to changelog. It also renamed the result tags that said binlog in the changelog suites and regenerated their .out files, except in the two suites that only run in cloud mode, test_cloud_changelog_compaction and test_cloud_changelog_publish_conflict: regenerating their .out files needs a cloud cluster running that code. Those two suites still carry nine tags that say binlog, such as qt_row_binlog_publish_conflict and order_qt_cloud_dup_binlog_compaction.

This renames the nine tags in the two groovy files and the matching "-- !tag --" lines in the two .out files, the same way apache#69311 renamed the tags of the other changelog suites (row_binlog -> changelog, binlog_compaction -> changelog_compaction). The queries are unchanged, so no result row changes. The .out files were edited by hand, only on the nine tag lines, instead of being regenerated.

### Release note

None

### Check List (For Author)

- Test: No need to test. Only result tag names change; the queries and the expected rows are unchanged. The two suites return early outside cloud mode and were not run locally.
- Behavior changed: No
- Does this need documentation: No

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

Copy link
Copy Markdown
Contributor Author

run buildall

@morningman
morningman merged commit 6b23aa8 into apache:master Oct 22, 2026
37 checks passed
@morningman
morningman deleted the changelog-t12-cloud-tags branch October 22, 2026 10:15
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants