Repository navigation
branch-4.2: [fix](be) Count variant data in information_schema.column_data_sizes - #69259
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
branch-pick-68444-to-4.2
branch
from
October 19, 2026 06:38
c3f6455 to
c6933d2
Compare
Member
Author
|
run buildall |
eldenmoon
force-pushed
the
branch-pick-68444-to-4.2
branch
from
October 19, 2026 07:39
c6933d2 to
edb85fc
Compare
Member
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Oct 20, 2026
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #68444
Adapted to branch-4.2:
be/test/storage/test_data/segment_flusher_format/*: the fixtures the original commitupdates do not exist on branch-4.2 (that test was never backported), so they stay deleted.
VariantColumnWriterImplmay own only a V1writer, so
get_total_data_pages_bytesdispatches toVariantV1ColumnWriter, which sumsits root, subcolumn and binary writers, instead of dereferencing a null V2 writer.
VariantSubcolumnWriterreports 0 before its writer exists.Tested locally with
./run-be-ut.sh --run --filter='VariantColumnWriterReaderTest.*:VariantUtilTest.*'(branch-4.2 code + this pick, RELEASE build):
VariantColumnWriterReaderTest.test_write_data_normal,doc_compact_writer_round_tripand the two writer helpers that now assert the variantdata page bytes, plus all 21
VariantUtilTesttests.VariantColumnWriterReaderTest.test_nested_iterfails, but it fails on branch-4.2 withoutthis change as well (
_process_nested_columnsno longer returns an error for a differentarray offset), so it is not caused by this pick.
The new regression suite
query_p0/system/test_query_sys_column_data_sizes_variantwas notrun locally (needs a cluster).