Repository navigation
branch-4.2: [fix](regression) Pin Variant mode in search document ID test (#69248) - #69250
Merged
Merged
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#68758, apache#69244 Problem Summary: Fuzzy sessions can enable Variant document mode for test_search_segment_document_ids, while parse_to_variant() produces a non-document Variant value. INSERT then fails before the document ID checks run. Explicitly disable document mode for this fixture. ### Release note None ### Check List (For Author) - Test: The official regression runner reproduced the conversion error with the inherited document-mode default enabled. After the fix, the existing suite passed all 16 V2/SNII golden checks with the same input. Validation used an isolated existing branch-4.2 ASAN FE/BE runtime. - Behavior changed: No production behavior changes. - Does this need documentation: No. (cherry picked from commit 654327b)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
yiguolei
approved these changes
Oct 19, 2026
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #69248 (source), #69244
Problem Summary: Backport the regression fixture fix from #69248. Fuzzy sessions can enable Variant document mode, making the fixture's INSERT fail when its
parse_to_variant()values use the non-document representation. Pindefault_variant_enable_doc_mode=falsebefore creating the table.Source commit:
654327b82d2c4976625ee55a3a94062c6dd7866d, cherry-picked with-x. The source PR is currently open; this backport uses that pinned head.Hunk audit
regression-test/suites/search/test_search_segment_document_ids.groovygit range-diffshows only the added cherry-pick provenance line in the commit message. There are no code adaptations.Release note
None
Check List (For Author)
./run-regression-test.sh --run --conf <local-config> -d search -s test_search_segment_document_idspassed in this branch-4.2 worktree with JDBCsessionVariables=default_variant_enable_doc_mode=true: 1 suite, 0 failures, all 16 V2/SNII golden checks executed. Expected output is unchanged.9c2283cfe1e53f1bd6b7473fa3168125ddf1c359. No ASAN report appeared in the focused backport run. No new kernel build or BE/FE unit test run was needed for this Groovy-only change.Check List (For Reviewer who merge this PR)