Repository navigation
[fix](regression) Move unstable cross-cloud storage suites to p2 - #68866
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
suxiaogang223
changed the title
### What problem does this PR solve? Issue Number: N/A Related PR: N/A Problem Summary: Six regression suites access remote COS/OBS endpoints and repeatedly fail with upload or connection timeouts across unrelated PRs. Move these suites and their existing golden files from p0 to p2, updating suite groups so P0, Cloud P0, and External pipelines exclude them while preserving p2 coverage. Suite bodies and golden contents are unchanged. ### Release note None ### Check List (For Author) - Test: Manual static validation of suite selection, exact change scope, unchanged suite bodies and golden files; git diff --check passed. Live cloud regression was not run. - Behavior changed: Yes, regression suite scheduling only. - Does this need documentation: No
5398bd5 to
a6b0f71
Compare
|
run buildall |
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review complete for PR #68866 at head a6b0f7142a26020347f43f15e623d03c0fa2fa52. No actionable new finding or existing P0/P1 inline blocker was found. There was no additional user review focus.
Goal and evidence. The PR moves six cross-cloud regression suites from P0 paths/tags to P2 and moves four matching golden files. All six suite bodies differ from the base only in their group tags; all four golden files are byte identical. The framework derives golden paths from suite-relative paths, so the moved files match their suites. P0 and External configs exclude p2 after group inclusion, while Cloud P0 selects p0. An explicit P2 run using the External configuration with -g p2 -xg '' can select the gated Paimon and refactor-storage suites. The default configuration alone does not enable those external gates; this is the established convention for nearby P2 external suites.
Critical checkpoints. Scope is small and focused: six suite moves and four golden moves, with no production SQL or code changes. No new concurrency, locks, lifecycle, static initialization, configuration item, dynamic-config behavior, storage format, protocol, function symbol, or FE/BE variable path is introduced. Parallel P0, Cloud P0, and External selection paths were checked; the existing gate conditions remain unchanged. Golden results and their section names were inspected; two moved suites had no golden file before or after. No new production transaction, persistence, write, crash-recovery, observability, or performance path is affected. These points are inapplicable beyond the unchanged regression bodies.
Validation and limits. The authoritative changed-path list and diff were reviewed, all ten new paths and six P2 tags were confirmed, old paths are absent, and git diff --check passed. This review was static only as required by the review contract: no build, regression test, live cloud access, or generated output run was performed. Three independent first-round reviews converged on no new valuable finding; the one candidate about default P2 feature gates was dismissed after verifying the explicit External-config P2 selection path. The final changed-path and unresolved-candidate sweep is clear.
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary:
Cross-cloud COS/OBS access repeatedly times out in regression runs for unrelated PRs, including
curlCode: 28during uploads and object-storage connection timeouts. Examples: External #103511, P0 #127021, and Cloud P0 #68212.Move the following suites to p2 directories and change their tier tags from
p0top2, preserving existingexternaltags:refactor_storage_param_s3_loadtest_s3_tvf_s3_storagetest_outfile_s3_storagepaimon_base_filesystemtest_file_tvf_s3test_outfile_with_different_s3Move the four existing golden files alongside their suites without changing their contents. P0, Cloud P0, and External pipelines exclude these suites, while their coverage remains available in p2. Suite bodies are unchanged.
Release note
None
Check List (For Author)
git diff --checkpassed. Live cloud regression was not run.Check List (For Reviewer who merge this PR)