Repository navigation
branch-4.1: [fix](function) Reject a non-constant seed in array_shuffle #68438 - #68832
Merged
Merged
Conversation
### What problem does this PR solve? Issue Number: None Related PR: #44901 Problem Summary: 1. `array_shuffle` now rejects a non-constant seed, which was silently ignored for every row but the first one of each block. 2. The seed now uses all 64 bits (`std::mt19937_64`), so any BIGINT seed works, including a negative one, which failed with an out-of-range error since #44901. 3. Every row is now shuffled on its own, so a constant array no longer gets the same order on every row, and blocks without a seed no longer repeat each other. doc: apache/doris-website#4176 ### Release note `array_shuffle` / `shuffle` rejects a non-constant seed, uses all 64 bits of the seed (so the order for a given seed changes), and shuffles every row on its own. ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [x] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [x] Yes. See the three points above. - Does this need documentation? - [ ] No. - [x] Yes. <!-- apache/doris-website PR link to be added --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Oct 10, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Oct 10, 2026
#68438 (#68832) Cherry-picked from #68438 Co-authored-by: Chenyang Sun <[email protected]> Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #68438