Skip to content

[fix](be) exclude wal from variant format validation - #68233

Merged
yiguolei merged 3 commits into
apache:branch-4.1.4from
zhangstar333:branch-4.1.4
Sep 20, 2026
Merged

[fix](be) exclude wal from variant format validation#68233
yiguolei merged 3 commits into
apache:branch-4.1.4from
zhangstar333:branch-4.1.4

Conversation

@zhangstar333

@zhangstar333 zhangstar333 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
WAL stores doris blocks directly and supports variant columns. exclude WAL from external variant file-format validation to avoid incorrectly returning a not-supported error.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

eldenmoon
eldenmoon reviewed Sep 20, 2026
View reviewed changes
Comment thread be/src/format_v2/table_reader.cpp Resolved
eldenmoon
eldenmoon approved these changes Sep 20, 2026
View reviewed changes

@eldenmoon eldenmoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei
yiguolei merged commit 9296830 into apache:branch-4.1.4 Sep 20, 2026
22 of 23 checks passed
yiguolei pushed a commit that referenced this pull request Sep 20, 2026
@zhangstar333
[fix](be) exclude wal from variant format validation (#68233) (#68242)
470a8b5 
### What problem does this PR solve?
Problem Summary:
WAL stores doris blocks directly and supports variant columns. exclude
WAL from external variant file-format validation to avoid incorrectly
returning a not-supported error.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
yiguolei pushed a commit that referenced this pull request Sep 21, 2026
@zhangstar333 @yiguolei
[fix](be) exclude wal from variant format validation (#68233) (#68242)
e5ad03d 
### What problem does this PR solve?
Problem Summary:
WAL stores doris blocks directly and supports variant columns. exclude
WAL from external variant file-format validation to avoid incorrectly
returning a not-supported error.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@morningman morningman mentioned this pull request Sep 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes
@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangstar333 @hello-stephen @yiguolei @eldenmoon