Skip to content

[feature](storage) Support row-level TTL - #65858

Merged
morningman merged 9 commits into
apache:masterfrom
AntiTopQuark:support_row_tll
Oct 29, 2026
Merged

[feature](storage) Support row-level TTL#65858
morningman merged 9 commits into
apache:masterfrom
AntiTopQuark:support_row_tll

Conversation

@AntiTopQuark

@AntiTopQuark AntiTopQuark commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #61056 #66084
Related PR: #None

Problem Summary:

Add create-time Row TTL support with a hidden TTL column for both source-time and direct-expiration tables. The implementation removes dynamic ALTER enablement and dedicated full schema-change/backfill paths, keeps TTL configured only at CREATE TABLE time, and treats TTL as a post-merge row visibility rule composed with delete sign. Storage keeps ordinary compaction policy while filtering expired rows during reads and natural rewrite paths. FE/BE tests and regression cases cover property validation, hidden column construction, tablet schema propagation, visibility filtering, partial updates, planning behavior, and ALTER rejection.

Release note

Support Row TTL configured at CREATE TABLE time; ALTER dynamic Row TTL enablement is not supported.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@AntiTopQuark

AntiTopQuark commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

1 similar comment
@AntiTopQuark

AntiTopQuark commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.62% (1908/2458)
Line Coverage 64.49% (34157/52968)
Region Coverage 64.92% (17578/27076)
Branch Coverage 54.06% (9419/17424)

@hello-stephen

hello-stephen commented Jul 22, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 1150 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72a3aece42b71c99312e28fecb1c09a817b5b81f, data reload: false

query5	
query6	
query7	
query8	
query9	
query10	
query11	
query12	
query13	
query14	
query14_1	
query15	
query16	
query17	
query18	
query19	
query20	
query21	
query22	
query23	
query23_1	
query24	
query24_1	
query25	
query26	
query27	
query28	
query29	
query30	
query31	
query32	
query33	
query34	
query35	
query36	
query37	
query38	
query39	
query39_1	
query40	
query41	
query42	
query43	
query44	
query45	
query46	
query47	
query48	
query49	
query50	
query51	
query52	
query53	
query54	
query55	
query56	
query57	
query58	
query59	
query60	
query61	
query62	
query63	
query64	
query65	
query66	
query67	
query68	
query69	
query70	
query71	
query72	
query73	
query74	
query75	
query76	
query77	
query78	
query79	
query80	
query81	
query82	
query83	
query84	
query85	
query86	
query87	
query88	
query89	
query90	
query91	
query92	
query93	
query94	
query95	
query96	
query97	
query98	
query99	
Total cold run time: 11707 ms
Total hot run time: 1150 ms

@AntiTopQuark

AntiTopQuark commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 63.14% (185/293) 🎉
Increment coverage report
Complete coverage report

@AntiTopQuark

AntiTopQuark commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.62% (1908/2458)
Line Coverage 64.48% (34156/52968)
Region Coverage 64.87% (17565/27076)
Branch Coverage 54.05% (9418/17424)

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 1146 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 77da12d4d1bcec15c17f79440271ead9f05b3323, data reload: false

query5	
query6	
query7	
query8	
query9	
query10	
query11	
query12	
query13	
query14	
query14_1	
query15	
query16	
query17	
query18	
query19	
query20	
query21	
query22	
query23	
query23_1	
query24	
query24_1	
query25	
query26	
query27	
query28	
query29	
query30	
query31	
query32	
query33	
query34	
query35	
query36	
query37	
query38	
query39	
query39_1	
query40	
query41	
query42	
query43	
query44	
query45	
query46	
query47	
query48	
query49	
query50	
query51	
query52	
query53	
query54	
query55	
query56	
query57	
query58	
query59	
query60	
query61	
query62	
query63	
query64	
query65	
query66	
query67	
query68	
query69	
query70	
query71	
query72	
query73	
query74	
query75	
query76	
query77	
query78	
query79	
query80	
query81	
query82	
query83	
query84	
query85	
query86	
query87	
query88	
query89	
query90	
query91	
query92	
query93	
query94	
query95	
query96	
query97	
query98	
query99	
Total cold run time: 11433 ms
Total hot run time: 1146 ms

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.68 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 77da12d4d1bcec15c17f79440271ead9f05b3323, data reload: false

query1	0.01	0.03	0.00
query2	0.14	0.08	0.09
query3	0.38	0.25	0.25
query4	1.61	0.25	0.25
query5	0.35	0.32	0.32
query6	1.16	0.68	0.67
query7	0.05	0.01	0.00
query8	0.09	0.08	0.07
query9	0.50	0.38	0.38
query10	0.59	0.60	0.61
query11	0.31	0.18	0.19
query12	0.31	0.18	0.18
query13	0.53	0.53	0.53
query14	0.95	0.94	0.93
query15	0.68	0.58	0.62
query16	0.40	0.39	0.38
query17	1.04	1.02	0.98
query18	0.31	0.29	0.30
query19	1.88	1.79	1.82
query20	0.02	0.01	0.01
query21	15.39	0.39	0.32
query22	4.78	0.13	0.14
query23	15.86	0.48	0.31
query24	2.44	0.62	0.43
query25	0.16	0.11	0.10
query26	0.75	0.28	0.21
query27	0.11	0.11	0.09
query28	3.49	0.84	0.50
query29	12.46	4.26	3.34
query30	0.38	0.26	0.26
query31	2.76	0.62	0.34
query32	3.23	0.60	0.47
query33	3.08	2.95	3.01
query34	15.71	4.02	3.37
query35	3.31	3.28	3.28
query36	0.65	0.54	0.53
query37	0.13	0.09	0.09
query38	0.08	0.06	0.06
query39	0.07	0.06	0.06
query40	0.20	0.17	0.17
query41	0.13	0.08	0.09
query42	0.08	0.06	0.07
query43	0.07	0.06	0.07
Total cold run time: 96.63 s
Total hot run time: 25.68 s

@AntiTopQuark

AntiTopQuark commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29699 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7798391050da54e21418af4ee6042642a84a35d8, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17756	4101	4085	4085
q2	2009	315	211	211
q3	10946	1403	935	935
q4	4732	470	344	344
q5	8314	866	564	564
q6	329	168	136	136
q7	861	807	610	610
q8	10620	1552	1596	1552
q9	5843	4352	4319	4319
q10	6814	1754	1434	1434
q11	512	342	327	327
q12	717	599	463	463
q13	18060	3331	2734	2734
q14	258	262	238	238
q15	q16	782	769	705	705
q17	1045	967	1013	967
q18	6924	5747	5648	5648
q19	1519	1326	1103	1103
q20	815	672	574	574
q21	5998	2540	2456	2456
q22	428	356	294	294
Total cold run time: 105282 ms
Total hot run time: 29699 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4446	4303	4290	4290
q2	275	327	209	209
q3	4545	4923	4349	4349
q4	2054	2145	1342	1342
q5	4401	4221	4206	4206
q6	230	176	173	173
q7	2170	1893	1602	1602
q8	2547	2238	2126	2126
q9	7866	7725	7712	7712
q10	4764	4650	4387	4387
q11	612	408	408	408
q12	763	757	532	532
q13	3325	3558	2916	2916
q14	287	297	275	275
q15	q16	732	719	648	648
q17	1361	1341	1324	1324
q18	7985	7397	6734	6734
q19	1198	1059	1050	1050
q20	2205	2207	1937	1937
q21	5167	4523	4369	4369
q22	521	443	427	427
Total cold run time: 57454 ms
Total hot run time: 51016 ms

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 177843 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7798391050da54e21418af4ee6042642a84a35d8, data reload: false

query5	4310	644	486	486
query6	490	229	209	209
query7	4916	618	342	342
query8	332	187	170	170
query9	8763	4039	4016	4016
query10	480	350	307	307
query11	5898	2324	2119	2119
query12	154	100	101	100
query13	1266	563	435	435
query14	6299	5214	4860	4860
query14_1	4184	4204	4178	4178
query15	214	203	176	176
query16	1048	472	433	433
query17	1089	697	550	550
query18	2451	452	335	335
query19	201	185	145	145
query20	113	104	103	103
query21	245	160	131	131
query22	13553	13392	13314	13314
query23	17071	16376	16001	16001
query23_1	16133	16181	16115	16115
query24	7578	1708	1256	1256
query24_1	1290	1284	1273	1273
query25	556	443	391	391
query26	1348	385	203	203
query27	2608	612	378	378
query28	4483	1983	2000	1983
query29	1072	621	488	488
query30	340	270	229	229
query31	1131	1095	1020	1020
query32	108	62	60	60
query33	527	326	274	274
query34	1172	1166	660	660
query35	779	781	673	673
query36	1212	1193	1092	1092
query37	158	114	96	96
query38	1863	1707	1665	1665
query39	868	860	844	844
query39_1	833	854	836	836
query40	281	161	140	140
query41	67	62	67	62
query42	93	92	90	90
query43	321	322	281	281
query44	1383	770	760	760
query45	190	180	169	169
query46	1073	1258	718	718
query47	2162	2105	1969	1969
query48	421	391	282	282
query49	579	413	306	306
query50	1119	440	335	335
query51	11080	11027	10805	10805
query52	85	88	75	75
query53	263	274	205	205
query54	288	224	204	204
query55	74	76	63	63
query56	276	293	289	289
query57	1304	1294	1202	1202
query58	287	258	247	247
query59	1540	1607	1406	1406
query60	307	267	248	248
query61	154	142	152	142
query62	536	495	434	434
query63	233	198	199	198
query64	2828	1042	896	896
query65	4744	4610	4628	4610
query66	1813	517	370	370
query67	29171	29210	29041	29041
query68	3153	1532	963	963
query69	419	296	268	268
query70	1044	935	947	935
query71	385	353	308	308
query72	3039	2698	2297	2297
query73	873	762	432	432
query74	5059	4907	4700	4700
query75	2524	2511	2135	2135
query76	2315	1191	806	806
query77	347	375	277	277
query78	11860	11713	11386	11386
query79	1238	1147	738	738
query80	601	546	441	441
query81	448	334	292	292
query82	235	156	117	117
query83	321	322	295	295
query84	285	154	129	129
query85	891	591	501	501
query86	320	297	269	269
query87	1802	1837	1744	1744
query88	3682	2760	2771	2760
query89	400	372	322	322
query90	2186	200	199	199
query91	201	193	160	160
query92	61	61	53	53
query93	1579	1515	937	937
query94	535	361	326	326
query95	809	520	500	500
query96	1070	796	372	372
query97	2651	2616	2500	2500
query98	215	223	210	210
query99	1081	1123	983	983
Total cold run time: 261670 ms
Total hot run time: 177843 ms

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7798391050da54e21418af4ee6042642a84a35d8, data reload: false

query1	0.01	0.01	0.00
query2	0.14	0.08	0.08
query3	0.36	0.24	0.24
query4	1.61	0.24	0.22
query5	0.33	0.31	0.31
query6	1.16	0.68	0.66
query7	0.03	0.00	0.00
query8	0.09	0.07	0.07
query9	0.50	0.37	0.38
query10	0.56	0.57	0.56
query11	0.31	0.17	0.17
query12	0.31	0.19	0.18
query13	0.51	0.53	0.52
query14	0.93	0.93	0.92
query15	0.67	0.59	0.59
query16	0.38	0.39	0.37
query17	0.97	0.99	0.98
query18	0.29	0.29	0.28
query19	1.86	1.75	1.80
query20	0.02	0.02	0.02
query21	15.38	0.38	0.31
query22	4.80	0.13	0.13
query23	15.79	0.48	0.31
query24	2.45	0.59	0.42
query25	0.15	0.11	0.09
query26	0.75	0.26	0.21
query27	0.11	0.09	0.10
query28	3.51	0.88	0.52
query29	12.49	4.22	3.33
query30	0.38	0.27	0.25
query31	2.76	0.61	0.33
query32	3.23	0.60	0.47
query33	2.88	2.88	2.99
query34	15.71	3.98	3.35
query35	3.30	3.25	3.25
query36	0.63	0.52	0.50
query37	0.12	0.10	0.09
query38	0.08	0.06	0.07
query39	0.07	0.06	0.06
query40	0.20	0.18	0.17
query41	0.13	0.08	0.07
query42	0.09	0.05	0.07
query43	0.08	0.07	0.07
Total cold run time: 96.13 s
Total hot run time: 25.3 s

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 65.53% (192/293) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 67.99% (531/781) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 58.10% (24600/42344)
Line Coverage 42.11% (245255/582457)
Region Coverage 38.02% (194944/512798)
Branch Coverage 39.13% (87870/224563)

@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 28801 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2c1234928ec6a210671f5c5f2e2bb15240b4f33, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17583	5202	5056	5056
q2	2160	300	269	269
q3	10230	1384	823	823
q4	4679	463	333	333
q5	7446	802	534	534
q6	179	178	149	149
q7	757	794	608	608
q8	9272	1328	1087	1087
q9	5574	4200	4214	4200
q10	6825	1290	1032	1032
q11	426	248	226	226
q12	640	402	289	289
q13	18078	3580	3054	3054
q14	269	268	245	245
q15	q16	726	712	650	650
q17	1213	749	584	584
q18	6985	6171	6128	6128
q19	1107	956	608	608
q20	392	339	229	229
q21	5369	2425	2480	2425
q22	389	328	272	272
Total cold run time: 100299 ms
Total hot run time: 28801 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5913	5890	5918	5890
q2	706	621	583	583
q3	5535	5722	5414	5414
q4	2056	2147	1588	1588
q5	5819	5697	5736	5697
q6	247	187	143	143
q7	2266	2037	1902	1902
q8	2840	2472	2474	2472
q9	7523	7494	7464	7464
q10	3626	3554	3167	3167
q11	582	407	375	375
q12	672	659	505	505
q13	3284	3590	2989	2989
q14	285	298	257	257
q15	q16	647	676	621	621
q17	7757	6975	6875	6875
q18	13049	12249	12921	12249
q19	980	792	800	792
q20	2131	2175	1901	1901
q21	5630	4545	4682	4545
q22	499	433	433	433
Total cold run time: 72047 ms
Total hot run time: 65862 ms

@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 151501 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2c1234928ec6a210671f5c5f2e2bb15240b4f33, data reload: false

query5	4312	601	444	444
query6	428	202	194	194
query7	4806	442	234	234
query8	327	161	146	146
query9	8795	3193	3195	3193
query10	488	311	266	266
query11	6026	3863	3576	3576
query12	150	96	88	88
query13	1255	449	350	350
query14	6063	3966	3644	3644
query14_1	3431	3471	3413	3413
query15	209	198	181	181
query16	948	427	406	406
query17	890	657	540	540
query18	2426	425	322	322
query19	207	164	134	134
query20	86	84	85	84
query21	211	126	113	113
query22	12960	12950	12827	12827
query23	13534	12948	12443	12443
query23_1	12519	12686	12618	12618
query24	7369	856	473	473
query24_1	496	484	482	482
query25	538	424	368	368
query26	1256	254	143	143
query27	2765	444	273	273
query28	4611	2046	2020	2020
query29	1584	598	455	455
query30	310	216	181	181
query31	1026	939	830	830
query32	152	93	90	90
query33	536	309	256	256
query34	907	850	514	514
query35	737	758	630	630
query36	812	832	733	733
query37	123	98	90	90
query38	1793	1753	1703	1703
query39	806	786	755	755
query39_1	727	728	738	728
query40	221	119	101	101
query41	73	68	67	67
query42	90	87	86	86
query43	348	370	313	313
query44	1316	709	710	709
query45	183	174	169	169
query46	830	968	595	595
query47	2913	2801	2875	2801
query48	299	301	218	218
query49	570	395	285	285
query50	677	288	215	215
query51	10301	10294	10319	10294
query52	79	85	69	69
query53	187	209	149	149
query54	248	201	170	170
query55	72	65	63	63
query56	216	230	226	226
query57	1664	1653	1561	1561
query58	271	263	268	263
query59	2145	2214	2030	2030
query60	270	241	219	219
query61	140	142	141	141
query62	382	344	274	274
query63	190	161	160	160
query64	2749	937	740	740
query65	3337	3259	3255	3255
query66	1781	429	302	302
query67	20167	20301	20133	20133
query68	2981	1007	620	620
query69	383	283	255	255
query70	835	794	787	787
query71	300	237	217	217
query72	2710	2576	2269	2269
query73	523	528	301	301
query74	4619	4517	4340	4340
query75	2318	2278	1911	1911
query76	2312	1024	591	591
query77	343	364	278	278
query78	10015	9737	9149	9149
query79	998	862	534	534
query80	844	407	329	329
query81	586	319	270	270
query82	585	132	112	112
query83	294	200	183	183
query84	317	126	105	105
query85	983	428	370	370
query86	351	239	232	232
query87	1995	1920	1820	1820
query88	3773	2774	2783	2774
query89	333	284	253	253
query90	1783	169	164	164
query91	166	147	127	127
query92	98	89	93	89
query93	993	987	578	578
query94	540	313	280	280
query95	570	379	312	312
query96	680	505	235	235
query97	2451	2423	2295	2295
query98	164	154	145	145
query99	763	764	639	639
Total cold run time: 234667 ms
Total hot run time: 151501 ms

@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2c1234928ec6a210671f5c5f2e2bb15240b4f33, data reload: false

query1	0.01	0.01	0.01
query2	0.14	0.08	0.08
query3	0.34	0.13	0.13
query4	1.61	0.13	0.14
query5	0.28	0.24	0.23
query6	1.15	0.64	0.64
query7	0.04	0.01	0.01
query8	0.10	0.07	0.07
query9	0.45	0.35	0.35
query10	0.61	0.60	0.60
query11	0.31	0.17	0.18
query12	0.32	0.18	0.19
query13	0.51	0.51	0.52
query14	0.95	0.94	0.93
query15	0.65	0.57	0.58
query16	0.35	0.35	0.36
query17	1.02	0.99	0.99
query18	0.30	0.27	0.28
query19	1.94	1.89	1.83
query20	0.02	0.01	0.02
query21	15.41	0.35	0.31
query22	4.92	0.13	0.13
query23	15.87	0.50	0.30
query24	1.99	0.61	0.39
query25	0.16	0.11	0.10
query26	0.76	0.26	0.20
query27	0.11	0.09	0.10
query28	3.44	0.84	0.39
query29	12.58	4.25	3.33
query30	0.34	0.17	0.15
query31	2.77	0.58	0.32
query32	3.22	0.59	0.47
query33	3.09	2.93	2.92
query34	15.88	4.06	3.44
query35	3.37	3.37	3.38
query36	0.58	0.52	0.49
query37	0.12	0.09	0.10
query38	0.08	0.06	0.06
query39	0.06	0.06	0.06
query40	0.19	0.18	0.16
query41	0.11	0.06	0.06
query42	0.06	0.06	0.06
query43	0.06	0.06	0.06
Total cold run time: 96.27 s
Total hot run time: 25.01 s

@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 67.90% (440/648) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 67.90% (440/648) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 68.98% (447/648) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen

hello-stephen commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 68.98% (447/648) 🎉
Increment coverage report
Complete coverage report

贾敬哲
[fix](regression) Fix compaction test compatibility on the Row TTL br…
99698b0 
…anch

### What problem does this PR solve?

Issue Number: N/A

Related PR: N/A

Problem Summary: The horizontal index-compaction BE test still calls the old
three-argument IndexColumnWriter::add_values API after the upstream interface
refactor, preventing BE UT compilation. Pass the aligned Slice descriptor
through the current two-argument API.

The shared regression helper also treats the normal full compaction E-2008
no-op as a failure after asynchronous failure checking was introduced for Row
TTL coverage. Restore the helper's original completion handling and remove the
framework assertions added for the changed contract. Existing gram, statistics,
and Row TTL regression suites remain unchanged.

The change is limited to test infrastructure and the BE test's API adaptation.
No production locking, lifetime, configuration, protocol, storage format, or
persistence behavior changes.

### Release note

None

### Check List (For Author)

- Test: clang-format v16, check-format, build hygiene, git diff --check,
  historical-content comparison, and independent static review passed during
  the original changes. The regression-framework build was blocked by an
  unwritable Maven cache. The targeted BE UT attempt was stopped during setup
  because installed third-party dependencies were absent; clang-tidy also
  lacked compile_commands.json. No runtime tests completed. Squashing only
  changes commit history; the resulting tree is verified unchanged.
- Behavior changed: Yes. Restore the regression helper's original completion
  handling for full compaction.
- Does this need documentation: No
@AntiTopQuark

AntiTopQuark commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 75.93% (492/648) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 67.48% (442/655) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (17/17) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 67.03% (32336/48241)
Line Coverage 51.86% (342143/659716)
Region Coverage 47.31% (278037/587636)
Branch Coverage 48.98% (131112/267659)

@hello-stephen

hello-stephen commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (16/16) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.51% (36229/46743)
Line Coverage 62.76% (409630/652681)
Region Coverage 59.30% (347193/585499)
Branch Coverage 60.14% (160566/267001)

@AntiTopQuark

AntiTopQuark commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

@morningman @luwei16 @morrySnow Hi, Please review this PR, thank u very much

@AntiTopQuark

AntiTopQuark commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

run performance

@AntiTopQuark

AntiTopQuark commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Hi @924060929 @CalvinKirs Please review this PR, thank u very much

924060929
924060929 approved these changes Oct 29, 2026
View reviewed changes

@924060929 924060929 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds create-time row TTL through a hidden column, write-time value binding, query-time visibility filtering, and versioned tablet GC policy updates. Source-column TTL retains the source timestamp; direct TTL stores an absolute expiration.

No actionable P0/P1/P2 issue was confirmed in the FE changes and necessary FE/BE boundaries. APPROVE within that scope. Reviewed DDL validation, writes and deletes, visibility planning, cache and optimization guards, metadata persistence, policy-update concurrency, protocol fields, and relevant test coverage. No builds or tests were run.

Three existing human approvals reference this exact head, so there is no subsequent delta. The supplied context reports successful P0 regression, but required-check rules are unknown and AI review remains pending. This is not a full BE review or an assertion that the entire PR is ready to merge.

Automated FE-focused static review (GPT-6.1 Sol, medium). No build or tests were run.

@morningman
morningman merged commit cbe1308 into apache:master Oct 29, 2026
38 checks passed
This was referenced Oct 29, 2026
Merged
Merged
@guptashivam04 guptashivam04 mentioned this pull request Oct 29, 2026
Open
6 of 10 tasks
This was referenced Nov 2, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes
@gavinchou gavinchou gavinchou approved these changes
@924060929 924060929 924060929 approved these changes
@morrySnow morrySnow morrySnow approved these changes
@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner
@liaoxin01 liaoxin01 Awaiting requested review from liaoxin01 liaoxin01 is a code owner
@englefly englefly Awaiting requested review from englefly englefly is a code owner
@starocean999 starocean999 Awaiting requested review from starocean999 starocean999 is a code owner
@mymeiyi mymeiyi Awaiting requested review from mymeiyi mymeiyi is a code owner
@deardeng deardeng Awaiting requested review from deardeng deardeng is a code owner
@luwei16 luwei16 Awaiting requested review from luwei16 luwei16 is a code owner
@eldenmoon eldenmoon Awaiting requested review from eldenmoon eldenmoon is a code owner
@csun5285 csun5285 Awaiting requested review from csun5285 csun5285 is a code owner
@airborne12 airborne12 Awaiting requested review from airborne12 airborne12 is a code owner
@seawinde seawinde Awaiting requested review from seawinde
@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner
@xiaokang xiaokang Awaiting requested review from xiaokang
@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner
@yujun777 yujun777 Awaiting requested review from yujun777 yujun777 is a code owner

Assignees

No one assigned

Labels

dev/4.1.6-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Row-level TTL

8 participants

@AntiTopQuark @hello-stephen @shuke987 @morningman @gavinchou @924060929 @morrySnow @yiguolei