Skip to content

branch-4.1: [fix](be) Fix release build warning in column mapper #65143 - #65845

Merged
yiguolei merged 2 commits into
branch-4.1from
auto-pick-65143-branch-4.1
Jul 22, 2026
Merged

branch-4.1: [fix](be) Fix release build warning in column mapper #65143#65845
yiguolei merged 2 commits into
branch-4.1from
auto-pick-65143-branch-4.1

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 21, 2026 •
edited by shuke987
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PRs: #65046, #65143, #65559

Problem Summary:

PR #65559 backported the FileScannerV2 series, including #65046, to branch-4.1, but did not include the follow-up Release compilation fix #65143. With NDEBUG, the diagnostic uses of the two caught exceptions are compiled out, so clang reports -Werror,-Wunused-exception-parameter while compiling be/src/format_v2/column_mapper.cpp.

This PR marks both catch parameters as [[maybe_unused]]. Debug diagnostics and Release fallback behavior are unchanged.

Cherry-picked from #65143.

Release note

None.

Check List (For Author)

  • Test
    • Regression test
    • Unit Test
    • Manual test
      • TeamCity Doris Compile build 1001872 passed on current head be72438f77af633fdd9d5d84b11e30a9b8202bd1.
    • No need to test or manual test.
  • Behavior changed:
    • No.
    • Yes.
  • Does this need documentation?
    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@github-actions
github-actions Bot requested a review from yiguolei as a code owner July 21, 2026 07:50
@hello-stephen

hello-stephen commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen hello-stephen reopened this Jul 21, 2026
@hello-stephen

hello-stephen commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

run buildall

@shuke987

shuke987 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

/review

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Codex automated review failed and did not complete.

Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 25th, 2026 6:03 AM.
Workflow run: https://github.com/apache/doris/actions/runs/29818229314

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@hello-stephen

hello-stephen commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.93% (28591/39204)
Line Coverage 56.35% (309226/548725)
Region Coverage 53.31% (257010/482148)
Branch Coverage 54.43% (113209/207979)

@hello-stephen

hello-stephen commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

skip buildall

@hello-stephen

hello-stephen commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

流水线已跑过了，昨天卡在license check , rebase后直接skip all

@yiguolei
yiguolei merged commit fd47cde into branch-4.1 Jul 22, 2026
31 of 33 checks passed
@hello-stephen
hello-stephen deleted the auto-pick-65143-branch-4.1 branch July 22, 2026 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @shuke987 @yiguolei @bobhan1