Skip to content

[feat](job) show first error message for routine load - #65553

Merged
sollhui merged 11 commits into
apache:masterfrom
sollhui:support-routine-load-first-error-msg
Jul 15, 2026
Merged

[feat](job) show first error message for routine load#65553
sollhui merged 11 commits into
apache:masterfrom
sollhui:support-routine-load-first-error-msg

Conversation

@sollhui

@sollhui sollhui commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

PR #55666 added the first data quality error to load responses, but Routine Load was not covered. Routine Load transaction attachments only propagated the error log URL, so users still had to open the URL to inspect the actual error.

Design

This PR:

  • Captures the first data quality error for both successful and failed Routine Load tasks.
  • Propagates first_error_msg through the Routine Load Thrift transaction attachment and cloud transaction attachment.
  • Limits the message using first_error_msg_max_length when constructing the FE transaction attachment.
  • Forwards Routine Load attachments through the live cloud abort transaction path.
  • Adds a separate FirstErrorMsg column to SHOW ROUTINE LOAD.
  • Appends FIRST_ERROR_MSG to information_schema.routine_load_jobs without changing existing column ordinals.
  • Keeps ERROR_LOG_URLS unchanged instead of embedding the message in the URL field.
  • Treats Error URLs and the first error message as transient diagnostics:
    • They are not persisted in Routine Load job metadata or cloud progress.
    • They are not restored during transaction replay.
    • They are cleared together when the current error-statistics window is reset.
  • Keeps the behavior of successful ordinary Stream Load unchanged.

Example

first_error_msg output:

first_error_msg: no partition for this tuple. Src line: 100|bad_row

The first error can be queried directly:

SHOW ROUTINE LOAD FOR job_name;

or

SELECT ERROR_LOG_URLS, FIRST_ERROR_MSG
FROM information_schema.routine_load_jobs
WHERE JOB_NAME = 'job_name';

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui

sollhui commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@sollhui

sollhui commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Codex automated review failed and did not complete.

Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 20th, 2026 12:23 AM.
Workflow run: https://github.com/apache/doris/actions/runs/29249038505

Please inspect the workflow logs and rerun the review after the underlying issue is resolved.

@sollhui
sollhui force-pushed the support-routine-load-first-error-msg branch from 46cf915 to 9f85868 Compare July 13, 2026 12:22
@sollhui

sollhui commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.39% (1896/2450)
Line Coverage 64.42% (34052/52862)
Region Coverage 64.85% (17531/27032)
Branch Coverage 54.03% (9396/17390)

@sollhui
sollhui force-pushed the support-routine-load-first-error-msg branch 2 times, most recently from 0f76348 to 43cb1e2 Compare July 13, 2026 13:13
@sollhui

sollhui commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.39% (1896/2450)
Line Coverage 64.46% (34075/52862)
Region Coverage 64.88% (17539/27032)
Branch Coverage 54.08% (9405/17390)

liaoxin01
liaoxin01 previously approved these changes Jul 13, 2026
View reviewed changes

@liaoxin01 liaoxin01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29969 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43cb1e2c729d367577090d6ab3c588086682eb44, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17591	4230	4140	4140
q2	2062	342	201	201
q3	10261	1493	852	852
q4	4706	478	339	339
q5	7500	863	583	583
q6	190	176	141	141
q7	797	851	629	629
q8	10031	1707	1661	1661
q9	6033	4471	4450	4450
q10	6809	1827	1528	1528
q11	505	364	315	315
q12	765	572	448	448
q13	18208	3409	2771	2771
q14	279	266	241	241
q15	q16	793	781	712	712
q17	1029	915	951	915
q18	7564	5784	5690	5690
q19	1197	1316	1104	1104
q20	736	671	528	528
q21	5677	2688	2411	2411
q22	440	361	310	310
Total cold run time: 103173 ms
Total hot run time: 29969 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4447	4433	4413	4413
q2	287	335	220	220
q3	4587	5012	4434	4434
q4	2085	2155	1375	1375
q5	4499	4390	4387	4387
q6	253	300	192	192
q7	2200	1821	1638	1638
q8	2591	2279	2282	2279
q9	8365	7760	7904	7760
q10	4772	4682	4255	4255
q11	579	429	389	389
q12	795	750	538	538
q13	3371	3689	2904	2904
q14	304	302	280	280
q15	q16	717	725	637	637
q17	1355	1495	1343	1343
q18	7828	7290	7269	7269
q19	1073	1070	1082	1070
q20	2249	2194	1929	1929
q21	5276	4593	4474	4474
q22	522	484	412	412
Total cold run time: 58155 ms
Total hot run time: 52198 ms

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 75.00% (12/16) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 180463 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43cb1e2c729d367577090d6ab3c588086682eb44, data reload: false

query5	4340	653	494	494
query6	456	226	194	194
query7	4839	624	344	344
query8	362	193	179	179
query9	8775	4107	4092	4092
query10	494	353	292	292
query11	5922	2387	2184	2184
query12	162	99	95	95
query13	1257	604	424	424
query14	6272	5266	4914	4914
query14_1	4272	4247	4283	4247
query15	211	208	175	175
query16	1058	487	457	457
query17	1109	712	574	574
query18	2712	463	340	340
query19	205	190	144	144
query20	109	107	104	104
query21	234	161	138	138
query22	13554	13602	13429	13429
query23	17506	16623	16225	16225
query23_1	16351	16411	16308	16308
query24	7506	1809	1323	1323
query24_1	1299	1320	1296	1296
query25	545	437	369	369
query26	1336	369	223	223
query27	2577	624	398	398
query28	4459	2047	2010	2010
query29	1054	632	483	483
query30	334	260	227	227
query31	1116	1082	977	977
query32	107	61	58	58
query33	506	314	253	253
query34	1183	1168	631	631
query35	778	787	669	669
query36	1392	1406	1216	1216
query37	154	107	93	93
query38	1887	1722	1628	1628
query39	941	918	894	894
query39_1	870	910	889	889
query40	249	176	159	159
query41	75	71	71	71
query42	98	99	101	99
query43	333	335	291	291
query44	1520	796	790	790
query45	214	198	180	180
query46	1106	1189	779	779
query47	2434	2352	2267	2267
query48	415	447	298	298
query49	603	441	320	320
query50	1064	430	355	355
query51	10647	10613	10682	10613
query52	89	92	81	81
query53	274	293	207	207
query54	305	264	252	252
query55	80	75	69	69
query56	323	302	299	299
query57	1462	1411	1351	1351
query58	294	269	261	261
query59	1633	1665	1449	1449
query60	316	278	276	276
query61	184	172	172	172
query62	695	658	586	586
query63	240	216	209	209
query64	2947	1172	961	961
query65	4890	4786	4771	4771
query66	1784	535	402	402
query67	29670	29428	29329	29329
query68	3212	1718	958	958
query69	416	303	261	261
query70	1067	956	979	956
query71	374	313	330	313
query72	3130	2772	2454	2454
query73	831	793	453	453
query74	5105	4952	4759	4759
query75	2627	2579	2260	2260
query76	2330	1200	809	809
query77	363	400	293	293
query78	12280	12417	11645	11645
query79	1379	1149	764	764
query80	1280	551	468	468
query81	538	326	277	277
query82	640	158	123	123
query83	361	319	297	297
query84	287	159	131	131
query85	961	576	500	500
query86	428	294	280	280
query87	1829	1829	1761	1761
query88	3762	2824	2790	2790
query89	461	412	354	354
query90	1915	204	196	196
query91	199	192	163	163
query92	67	63	58	58
query93	1721	1495	991	991
query94	718	350	340	340
query95	794	607	481	481
query96	1038	843	337	337
query97	2722	2706	2598	2598
query98	217	219	204	204
query99	1154	1175	1029	1029
Total cold run time: 266792 ms
Total hot run time: 180463 ms

@hello-stephen

hello-stephen commented Jul 13, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 25 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43cb1e2c729d367577090d6ab3c588086682eb44, data reload: false

query1	0.00	0.00	0.00
query2	0.10	0.05	0.05
query3	0.25	0.14	0.13
query4	1.61	0.14	0.14
query5	0.25	0.23	0.22
query6	1.23	1.09	1.06
query7	0.07	0.02	0.01
query8	0.06	0.05	0.03
query9	0.40	0.33	0.31
query10	0.54	0.55	0.57
query11	0.20	0.15	0.15
query12	0.19	0.15	0.15
query13	0.48	0.48	0.48
query14	1.02	1.00	1.00
query15	0.61	0.59	0.59
query16	0.31	0.35	0.32
query17	1.11	1.11	1.13
query18	0.23	0.22	0.22
query19	2.03	1.98	1.90
query20	0.02	0.01	0.01
query21	15.43	0.23	0.13
query22	4.85	0.06	0.05
query23	16.11	0.31	0.12
query24	3.04	0.44	0.33
query25	0.11	0.07	0.05
query26	0.76	0.21	0.16
query27	0.05	0.04	0.04
query28	3.49	1.01	0.53
query29	12.55	4.03	3.18
query30	0.28	0.16	0.15
query31	2.77	0.61	0.32
query32	3.22	0.59	0.48
query33	3.15	3.20	3.20
query34	15.59	4.48	3.50
query35	3.49	3.53	3.54
query36	0.56	0.44	0.43
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.17	0.15
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.05	0.03	0.03
Total cold run time: 96.7 s
Total hot run time: 25 s

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 80.65% (25/31) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29437 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a08f5a2169ac1b9a2ae67e31fbcfff0eb5d04f7f, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17677	4127	4107	4107
q2	2023	339	200	200
q3	10253	1474	813	813
q4	4687	475	338	338
q5	7543	853	572	572
q6	189	172	138	138
q7	768	840	611	611
q8	9376	1570	1581	1570
q9	5576	4365	4373	4365
q10	6736	1747	1460	1460
q11	508	340	312	312
q12	700	558	431	431
q13	18113	3397	2739	2739
q14	268	265	249	249
q15	q16	787	770	710	710
q17	1031	898	943	898
q18	7155	5740	5634	5634
q19	1195	1321	1065	1065
q20	796	659	552	552
q21	5557	2663	2380	2380
q22	433	354	293	293
Total cold run time: 101371 ms
Total hot run time: 29437 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4426	4336	4377	4336
q2	295	319	218	218
q3	4591	5006	4452	4452
q4	2032	2153	1351	1351
q5	4393	4273	4283	4273
q6	221	179	127	127
q7	1761	1675	1854	1675
q8	2664	2180	2178	2178
q9	7996	8274	7638	7638
q10	4638	4664	4166	4166
q11	577	460	409	409
q12	805	769	558	558
q13	3237	3500	2955	2955
q14	299	304	266	266
q15	q16	710	726	642	642
q17	1348	1314	1331	1314
q18	7859	7361	7353	7353
q19	1138	1114	1099	1099
q20	2214	2210	1931	1931
q21	5215	4564	4383	4383
q22	519	445	425	425
Total cold run time: 56938 ms
Total hot run time: 51749 ms

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 178000 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a08f5a2169ac1b9a2ae67e31fbcfff0eb5d04f7f, data reload: false

query5	4309	631	491	491
query6	476	212	200	200
query7	4850	573	343	343
query8	337	186	167	167
query9	8769	4116	4132	4116
query10	458	361	325	325
query11	5887	2354	2124	2124
query12	167	105	115	105
query13	1269	576	404	404
query14	6264	5219	4933	4933
query14_1	4268	4239	4268	4239
query15	209	206	180	180
query16	1049	490	455	455
query17	1133	728	589	589
query18	2720	491	363	363
query19	214	192	158	158
query20	115	109	105	105
query21	231	160	136	136
query22	13543	13598	13367	13367
query23	17272	16453	16187	16187
query23_1	16362	16232	16254	16232
query24	7501	1765	1284	1284
query24_1	1331	1283	1266	1266
query25	569	451	395	395
query26	1323	377	219	219
query27	2473	582	359	359
query28	4374	2012	1998	1998
query29	1096	631	494	494
query30	337	258	233	233
query31	1128	1097	984	984
query32	103	63	63	63
query33	546	332	254	254
query34	1182	1181	632	632
query35	768	791	671	671
query36	1222	1184	1078	1078
query37	153	113	138	113
query38	1882	1702	1644	1644
query39	875	884	870	870
query39_1	831	856	847	847
query40	237	156	139	139
query41	68	64	62	62
query42	92	95	91	91
query43	319	330	277	277
query44	1400	771	765	765
query45	193	193	173	173
query46	1068	1183	722	722
query47	2088	2104	2078	2078
query48	398	409	298	298
query49	589	416	303	303
query50	1079	414	335	335
query51	10994	10929	10833	10833
query52	86	89	74	74
query53	255	268	198	198
query54	278	240	222	222
query55	76	70	65	65
query56	297	293	263	263
query57	1297	1271	1195	1195
query58	282	261	252	252
query59	1579	1635	1431	1431
query60	297	266	244	244
query61	154	150	142	142
query62	556	495	428	428
query63	231	200	202	200
query64	2770	1053	887	887
query65	4720	4605	4576	4576
query66	1774	495	372	372
query67	29324	29156	29078	29078
query68	3124	1569	1018	1018
query69	409	311	307	307
query70	1071	961	954	954
query71	331	317	287	287
query72	3176	2628	2353	2353
query73	800	817	424	424
query74	5022	4893	4712	4712
query75	2490	2499	2112	2112
query76	2326	1184	767	767
query77	363	380	278	278
query78	11980	11835	11202	11202
query79	1430	1147	747	747
query80	1303	537	461	461
query81	524	317	278	278
query82	629	166	129	129
query83	363	326	313	313
query84	284	166	129	129
query85	975	607	510	510
query86	421	289	275	275
query87	1849	1815	1748	1748
query88	3701	2807	2796	2796
query89	428	368	317	317
query90	2004	205	191	191
query91	198	184	158	158
query92	65	61	59	59
query93	1673	1470	918	918
query94	733	348	303	303
query95	799	492	566	492
query96	1017	770	340	340
query97	2649	2581	2444	2444
query98	211	202	195	195
query99	1073	1112	987	987
Total cold run time: 263848 ms
Total hot run time: 178000 ms

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 24.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a08f5a2169ac1b9a2ae67e31fbcfff0eb5d04f7f, data reload: false

query1	0.01	0.00	0.01
query2	0.10	0.05	0.05
query3	0.26	0.14	0.14
query4	1.62	0.13	0.12
query5	0.24	0.23	0.22
query6	1.25	1.04	1.04
query7	0.04	0.01	0.01
query8	0.06	0.04	0.03
query9	0.38	0.31	0.31
query10	0.54	0.55	0.55
query11	0.19	0.14	0.14
query12	0.18	0.14	0.15
query13	0.47	0.47	0.49
query14	1.03	1.00	1.01
query15	0.62	0.60	0.58
query16	0.32	0.32	0.32
query17	1.11	1.12	1.11
query18	0.23	0.20	0.20
query19	2.07	1.98	1.95
query20	0.02	0.01	0.01
query21	15.45	0.22	0.13
query22	4.96	0.06	0.05
query23	16.14	0.32	0.12
query24	2.91	0.42	0.30
query25	0.11	0.05	0.04
query26	0.73	0.20	0.14
query27	0.04	0.04	0.04
query28	3.51	0.90	0.54
query29	12.48	4.02	3.16
query30	0.27	0.16	0.16
query31	2.77	0.56	0.31
query32	3.24	0.58	0.48
query33	3.13	3.12	3.26
query34	15.64	4.16	3.52
query35	3.52	3.49	3.52
query36	0.55	0.42	0.41
query37	0.08	0.06	0.06
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.09	0.03	0.04
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.72 s
Total hot run time: 24.76 s

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.83% (30281/40465)
Line Coverage 58.88% (332921/565375)
Region Coverage 55.59% (279066/501964)
Branch Coverage 56.90% (123553/217150)

@hello-stephen

hello-stephen commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 28.85% (30/104) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@sollhui
sollhui merged commit 82e90ef into apache:master Jul 15, 2026
36 of 37 checks passed
@sollhui
sollhui deleted the support-routine-load-first-error-msg branch July 15, 2026 06:41
This was referenced Jul 15, 2026
Merged
Merged
sollhui added a commit to sollhui/doris that referenced this pull request Jul 16, 2026
@sollhui
pick apache#65553
1ff0bc1
sollhui added a commit to sollhui/doris that referenced this pull request Jul 16, 2026
@sollhui
pick apache#65553
7c32d77
morningman pushed a commit that referenced this pull request Jul 17, 2026
@sollhui
branch-4.0: [feat](job) show first error message for routine load (#6…
7d1d5eb 
…5661)

pick #65553
yiguolei pushed a commit that referenced this pull request Jul 23, 2026
@sollhui
branch-4.1: [feat](job) show first error message for routine load (#6…
491819a 
…5662)

pick #65553
@morningman morningman mentioned this pull request Aug 11, 2026
Open
csun5285 added a commit to csun5285/doris that referenced this pull request Nov 3, 2026
@csun5285 @claude
[chore](build) Require new thrift/proto ids to land on master first
3cbcebc 
### What problem does this PR solve?

Issue Number: None

Related PR: apache#69658, apache#68500, apache#61325, apache#65553

Problem Summary: Release branches have been allocating thrift ids and enum
values on their own, and those ids later collide with master. Comparing
branch-4.0/4.1/4.2/master shows, for example:
- TQueryOptions 237 is paimon_blob_max_size on branch-4.1 (apache#69658, merged
  directly to branch-4.1) and spill_analytic_sink_mem_limit_bytes on master
  (apache#68500); both are i64, so a mixed cluster silently reads one as the other.
- TRLTaskTxnCommitAttachment 12 is firstErrorMsg on 4.0/4.1/4.2 but
  kinesisRLTaskProgress on master, because the backport of apache#65553 renumbered
  firstErrorMsg into the gap left by the unpicked apache#61325.
- TSchemaTableType values 62-72 differ between 4.0, 4.1/4.2 and master.

The existing rule only says an id must mean the same thing everywhere; it
does not say where an id is allocated, so each branch picks the next free
number. This adds the rule to gensrc/AGENTS.md (summarized in the root
AGENTS.md and the code-review skill): a new id or enum value is added on
master first, a release-only feature still reserves its id on master, picks
keep master's numbers, enum values are written explicitly, and a
release-branch PR that adds an id master does not have is not mergeable.

### Release note

None

### Check List (For Author)

- Test: No need to test (documentation-only change)
- Behavior changed: No
- Does this need documentation: No

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@gavinchou gavinchou gavinchou approved these changes
@liaoxin01 liaoxin01 liaoxin01 approved these changes
@starocean999 starocean999 starocean999 approved these changes
@luwei16 luwei16 Awaiting requested review from luwei16 luwei16 is a code owner
@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner
@924060929 924060929 Awaiting requested review from 924060929 924060929 is a code owner
@englefly englefly Awaiting requested review from englefly englefly is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.8-merged dev/4.1.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sollhui @hello-stephen @gavinchou @liaoxin01 @starocean999 @morningman @yiguolei