Repository navigation
[branch-4.1][fix](regression) Use local HTTP resources in TVF test - #65313
Merged
yiguolei merged 1 commit intoJul 8, 2026
Merged
Conversation
(cherry picked from commit 553c23d)
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Gabriel39
marked this pull request as ready for review
July 7, 2026 08:15
Contributor
Author
|
run buildall |
yiguolei
approved these changes
Jul 8, 2026
yiguolei
pushed a commit
that referenced
this pull request
Jul 23, 2026
### What problem does this PR solve? `test_http_tvf` starts an in-process HTTP server on the regression runner and asks Doris BE nodes to read from it. In branch-4.1 P2 build 203694, `externalEnvIp` is `127.0.0.1`, so the case builds a URL such as `http://127.0.0.1:46739/...`. The remote BE interprets loopback as itself and fails with `Connection refused`. ### What is changed? Keep an explicit `httpTvfHost` override, but reject loopback/any-local values inherited from `externalEnvIp` and fall back to the runner host address. TeamCity: http://172.20.48.17:8111/buildConfiguration/Doris_Doris_x64_branch41_Regression_P2/203694 Related backport: #65313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Backport #65299 to branch-4.1.
This updates the HTTP TVF regression test to serve local
regression-test/datafiles through an in-process HTTP server instead of fetching raw GitHub-hosted URLs.Notes
Resolved the suite-tag conflict by preserving branch-4.1's existing
p2classification.Validation
git diff --check origin/branch-4.1..codex/backport-65299-branch-4.1regression-test/datafiles referenced byhttpUrl(...)exist on the backport branch.