Skip to content

[fix](filecache) add OFFSET column for table file_cache_info - #59645

Merged
gavinchou merged 1 commit into
apache:masterfrom
freemandealer:fix-filecacheinfo
Jan 12, 2026
Merged

[fix](filecache) add OFFSET column for table file_cache_info#59645
gavinchou merged 1 commit into
apache:masterfrom
freemandealer:fix-filecacheinfo

Conversation

@freemandealer

@freemandealer freemandealer commented Jan 7, 2026

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer

freemandealer commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

run buildall

@doris-robot

doris-robot commented Jan 7, 2026

Copy link
Copy Markdown
TPC-H: Total hot run time: 31966 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 014f249df5011ecee0069864869acc5295fbfb37, data reload: false

------ Round 1 ----------------------------------
q1	17608	4248	4041	4041
q2	2009	364	240	240
q3	10164	1294	736	736
q4	10225	908	327	327
q5	7493	2050	1894	1894
q6	192	169	139	139
q7	978	784	663	663
q8	9294	1426	1141	1141
q9	4879	4528	4619	4528
q10	6802	1833	1429	1429
q11	536	321	302	302
q12	688	740	602	602
q13	17790	3867	3101	3101
q14	293	290	271	271
q15	588	514	522	514
q16	689	670	626	626
q17	670	758	561	561
q18	6724	6298	6857	6298
q19	1143	1068	671	671
q20	421	404	286	286
q21	3225	2583	2558	2558
q22	1096	1128	1038	1038
Total cold run time: 103507 ms
Total hot run time: 31966 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4315	4225	4200	4200
q2	354	410	348	348
q3	2292	2758	2405	2405
q4	1438	1862	1447	1447
q5	4614	4362	4327	4327
q6	210	172	125	125
q7	2234	1905	1785	1785
q8	2539	2342	2381	2342
q9	7137	7325	7040	7040
q10	2398	2687	2288	2288
q11	575	507	466	466
q12	688	803	636	636
q13	3732	3882	3066	3066
q14	260	286	257	257
q15	523	501	483	483
q16	618	642	609	609
q17	1096	1255	1320	1255
q18	7249	7360	7034	7034
q19	836	797	819	797
q20	1891	1936	1783	1783
q21	4573	4322	4116	4116
q22	1121	1036	982	982
Total cold run time: 50693 ms
Total hot run time: 47791 ms

@doris-robot

doris-robot commented Jan 7, 2026

Copy link
Copy Markdown
TPC-DS: Total hot run time: 172947 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 014f249df5011ecee0069864869acc5295fbfb37, data reload: false

query5	4447	589	465	465
query6	348	233	206	206
query7	4217	445	253	253
query8	343	242	222	222
query9	8774	2640	2684	2640
query10	512	366	319	319
query11	15296	15017	14872	14872
query12	173	112	116	112
query13	1244	477	375	375
query14	6106	2941	2740	2740
query14_1	2580	2660	2647	2647
query15	209	197	176	176
query16	994	480	471	471
query17	1117	681	578	578
query18	2465	441	358	358
query19	231	220	201	201
query20	128	120	114	114
query21	219	137	126	126
query22	3910	4171	4143	4143
query23	15982	15571	15168	15168
query23_1	15397	15362	15396	15362
query24	7374	1555	1191	1191
query24_1	1212	1189	1205	1189
query25	573	472	444	444
query26	1248	271	160	160
query27	2751	444	294	294
query28	4552	2137	2132	2132
query29	853	576	463	463
query30	307	244	213	213
query31	793	673	552	552
query32	83	74	71	71
query33	548	344	306	306
query34	884	889	522	522
query35	769	815	711	711
query36	871	898	862	862
query37	133	101	88	88
query38	2743	2780	2668	2668
query39	771	759	736	736
query39_1	701	707	724	707
query40	226	138	122	122
query41	75	70	68	68
query42	108	103	108	103
query43	442	430	412	412
query44	1306	730	733	730
query45	190	184	179	179
query46	847	958	590	590
query47	1408	1483	1400	1400
query48	316	331	258	258
query49	626	434	344	344
query50	634	290	204	204
query51	3764	3763	3756	3756
query52	107	117	99	99
query53	297	325	275	275
query54	298	273	294	273
query55	79	77	69	69
query56	287	292	293	292
query57	961	999	926	926
query58	266	249	257	249
query59	2124	2059	2167	2059
query60	318	315	305	305
query61	167	165	162	162
query62	400	348	310	310
query63	303	266	277	266
query64	5067	1303	989	989
query65	3656	3711	3715	3711
query66	1433	420	298	298
query67	15134	15659	14803	14803
query68	6580	970	761	761
query69	503	352	310	310
query70	1033	975	844	844
query71	360	297	274	274
query72	6135	3358	3410	3358
query73	752	719	306	306
query74	8777	8836	8567	8567
query75	2864	2838	2511	2511
query76	3812	1064	641	641
query77	519	357	286	286
query78	9600	9671	9152	9152
query79	1549	902	580	580
query80	655	579	472	472
query81	519	265	234	234
query82	208	144	110	110
query83	268	251	239	239
query84	262	121	103	103
query85	900	529	459	459
query86	387	328	282	282
query87	2881	2842	2737	2737
query88	3150	2221	2190	2190
query89	381	344	336	336
query90	2196	150	140	140
query91	174	163	140	140
query92	86	69	63	63
query93	1863	894	520	520
query94	580	312	300	300
query95	576	370	303	303
query96	577	452	209	209
query97	2306	2379	2264	2264
query98	228	204	199	199
query99	567	589	495	495
Total cold run time: 252877 ms
Total hot run time: 172947 ms

@doris-robot

doris-robot commented Jan 7, 2026

Copy link
Copy Markdown
ClickBench: Total hot run time: 26.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 014f249df5011ecee0069864869acc5295fbfb37, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.27	0.27	0.26
query6	1.14	0.67	0.66
query7	0.03	0.03	0.03
query8	0.05	0.03	0.04
query9	0.57	0.50	0.49
query10	0.55	0.55	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.59
query14	0.95	0.97	0.96
query15	0.80	0.77	0.79
query16	0.41	0.40	0.39
query17	0.96	1.09	1.00
query18	0.23	0.21	0.22
query19	1.97	1.85	1.73
query20	0.02	0.01	0.01
query21	15.43	0.29	0.14
query22	4.95	0.06	0.05
query23	15.77	0.30	0.10
query24	1.35	0.23	0.65
query25	0.11	0.07	0.07
query26	0.16	0.13	0.12
query27	0.13	0.05	0.05
query28	4.89	1.04	0.88
query29	12.59	3.91	3.15
query30	0.28	0.14	0.12
query31	2.82	0.64	0.38
query32	3.25	0.58	0.45
query33	2.95	3.03	3.02
query34	16.71	5.10	4.43
query35	4.44	4.46	4.49
query36	0.66	0.50	0.49
query37	0.10	0.07	0.06
query38	0.08	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.91 s
Total hot run time: 26.67 s

@doris-robot

doris-robot commented Jan 7, 2026

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 0.00% (0/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.10% (18976/35739)
Line Coverage 39.12% (175772/449312)
Region Coverage 33.66% (136086/404326)
Branch Coverage 34.65% (58765/169587)

@hello-stephen

hello-stephen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.94% (25834/34939)
Line Coverage 61.28% (274607/448093)
Region Coverage 56.21% (229576/408445)
Branch Coverage 58.08% (98816/170136)

@hello-stephen

hello-stephen commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@freemandealer

freemandealer commented Jan 8, 2026

Copy link
Copy Markdown
Member Author

run vault_p0

gavinchou
gavinchou reviewed Jan 8, 2026
View reviewed changes
Comment thread be/src/exec/schema_scanner/schema_file_cache_info_scanner.cpp
column_values[row_idx] = hash;
break;
case 3: // TYPE
case 4: // TYPE

@gavinchou gavinchou Jan 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any compatibility issues?

gavinchou
gavinchou reviewed Jan 8, 2026
View reviewed changes

@gavinchou gavinchou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2026
@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actions Bot commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jan 9, 2026
View reviewed changes

@dataroaring dataroaring left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen

hello-stephen commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.94% (25833/34939)
Line Coverage 61.28% (274593/448093)
Region Coverage 56.19% (229511/408445)
Branch Coverage 58.08% (98813/170136)

@hello-stephen

hello-stephen commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@gavinchou
gavinchou merged commit c4c3d14 into apache:master Jan 12, 2026
32 of 36 checks passed
zzzxl1993 pushed a commit to zzzxl1993/doris that referenced this pull request Jan 13, 2026
@freemandealer @zzzxl1993
[fix](filecache) add OFFSET column for table file_cache_info (apache#…
3411c5b 
…59645)
freemandealer added a commit to freemandealer/doris that referenced this pull request Mar 20, 2026
@freemandealer
[fix](filecache) add OFFSET column for table file_cache_info (apache#…
c9fc497 
…59645)
@freemandealer freemandealer mentioned this pull request Mar 20, 2026
Merged
16 tasks
yiguolei pushed a commit that referenced this pull request Mar 21, 2026
@freemandealer
branch-4.1:[enhancement](filecache) filecache meta persist PRs compil…
73bbd4d 
…ation (#61581)

pick the following PRs/Commits:

  - #57072 -> 30406d6
  - #57783 -> 4cbae8a
  - #57922 -> 0918952
  - #58082 -> 9f9a3e4
  - #59259 -> 9f2c6ed
  - #59269 -> e010d8d
  - #59311 -> d336eed
  - #59314 -> f7aa74e
  - #59645 -> c4c3d14
  - #60252 -> b1585e1
  - #60269 -> 26f44b5

 - #59645 -> c4c3d14
 * #60252 -> b1585e1
 * #60269 -> 26f44b5
 * #59269 -> e010d8d

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Signed-off-by: zhengyu <[email protected]>
Signed-off-by: freemandealer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes
@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@freemandealer @hello-stephen @doris-robot @gavinchou @dataroaring