Skip to content

branch-4.0: [fix] remove useless const_cast and explain const_cast(1) #55943 - #58117

Merged
yiguolei merged 1 commit into
branch-4.0from
auto-pick-55943-branch-4.0
Nov 19, 2025
Merged

yiguolei merged 1 commit into
branch-4.0from
auto-pick-55943-branch-4.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #55943

### What problem does this PR solve?
 go through whole be/ and find all const_cast

Issue Number: #55057 

Problem Summary:
1. remove useless const_cast
2. explain why using const_cast does not result in undefined behavior
3. don't modify some const_cast
    (1) some code in DBUG_EXECUTE_IF or test file
    (2) underlying data structures, such as cow
    (3) const_cast<const T*>


### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions
github-actions Bot requested a review from yiguolei as a code owner November 18, 2025 08:34
@Thearas

Thearas commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Thearas

Thearas commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 44.19% (19/43) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.80% (18158/34388)
Line Coverage 38.13% (165286/433487)
Region Coverage 33.14% (128349/387330)
Branch Coverage 33.95% (55377/163110)

@yiguolei yiguolei closed this Nov 19, 2025
@yiguolei yiguolei reopened this Nov 19, 2025
@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2025
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit 9889667 into branch-4.0 Nov 19, 2025
24 of 27 checks passed
@github-actions
github-actions Bot deleted the auto-pick-55943-branch-4.0 branch November 19, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants