Skip to content

[Bug](udf) fix the _udf_close_workers thread pool not stop when exit - #57918

Merged
yiguolei merged 1 commit into
apache:masterfrom
zhangstar333:udf_close_pool
Nov 12, 2025
Merged

[Bug](udf) fix the _udf_close_workers thread pool not stop when exit#57918
yiguolei merged 1 commit into
apache:masterfrom
zhangstar333:udf_close_pool

Conversation

@zhangstar333

@zhangstar333 zhangstar333 commented Nov 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
this pr introuced #55302
_udf_close_workers thread pool not stop when exit

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

RoanHeNaN
RoanHeNaN approved these changes Nov 11, 2025
View reviewed changes

@RoanHeNaN RoanHeNaN left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhangstar333

zhangstar333 commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions

github-actions Bot commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Nov 11, 2025
@github-actions

github-actions Bot commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot

doris-robot commented Nov 11, 2025

Copy link
Copy Markdown
TPC-H: Total hot run time: 35381 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0b8ec407a8529b038c31ee5524ec104a8c4fd131, data reload: false

------ Round 1 ----------------------------------
q1	17653	5271	5115	5115
q2	2033	320	212	212
q3	10224	1391	741	741
q4	10218	869	368	368
q5	7526	2434	2395	2395
q6	199	172	137	137
q7	931	780	640	640
q8	9368	1287	1127	1127
q9	7062	5179	5248	5179
q10	6898	2269	1812	1812
q11	497	311	300	300
q12	338	374	241	241
q13	17795	3675	3015	3015
q14	238	239	213	213
q15	591	527	503	503
q16	1048	998	963	963
q17	599	899	371	371
q18	7399	7538	8069	7538
q19	1203	987	579	579
q20	377	363	237	237
q21	4596	3843	2636	2636
q22	1174	1059	1093	1059
Total cold run time: 107967 ms
Total hot run time: 35381 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5394	5360	5446	5360
q2	252	321	224	224
q3	2413	2883	2519	2519
q4	1515	1930	1502	1502
q5	4591	4532	4433	4433
q6	221	181	139	139
q7	2096	1923	1838	1838
q8	2674	2555	2584	2555
q9	7338	7431	7176	7176
q10	3060	3248	2883	2883
q11	588	530	512	512
q12	648	713	548	548
q13	3262	3715	3092	3092
q14	279	281	274	274
q15	531	487	493	487
q16	1012	1056	1002	1002
q17	1137	1535	1324	1324
q18	7359	7235	7008	7008
q19	770	799	876	799
q20	1970	1975	1790	1790
q21	4843	4500	4349	4349
q22	1136	1064	1001	1001
Total cold run time: 53089 ms
Total hot run time: 50815 ms

@doris-robot

doris-robot commented Nov 11, 2025

Copy link
Copy Markdown
TPC-DS: Total hot run time: 188181 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0b8ec407a8529b038c31ee5524ec104a8c4fd131, data reload: false

query1	1054	397	397	397
query2	6561	1717	1738	1717
query3	6772	230	219	219
query4	26565	23400	23143	23143
query5	4406	634	507	507
query6	348	247	230	230
query7	4671	496	302	302
query8	305	245	247	245
query9	8719	2608	2622	2608
query10	456	332	286	286
query11	15698	15614	14829	14829
query12	190	120	114	114
query13	1668	570	435	435
query14	12715	9263	9295	9263
query15	251	183	181	181
query16	7792	668	517	517
query17	1635	798	641	641
query18	2057	439	337	337
query19	278	207	181	181
query20	134	132	122	122
query21	228	133	120	120
query22	4027	4070	3907	3907
query23	34023	33308	33019	33019
query24	8236	2466	2433	2433
query25	600	545	540	540
query26	1231	282	156	156
query27	2690	499	348	348
query28	4353	2242	2207	2207
query29	770	606	496	496
query30	305	223	197	197
query31	933	812	733	733
query32	85	72	78	72
query33	588	380	332	332
query34	793	844	531	531
query35	821	825	789	789
query36	952	1013	910	910
query37	126	109	86	86
query38	3585	3556	3474	3474
query39	1472	1423	1399	1399
query40	229	130	123	123
query41	65	63	61	61
query42	146	116	111	111
query43	504	494	479	479
query44	1266	747	752	747
query45	186	186	179	179
query46	875	996	640	640
query47	1742	1785	1722	1722
query48	397	419	312	312
query49	788	547	446	446
query50	654	711	408	408
query51	3986	3938	3831	3831
query52	113	107	112	107
query53	237	267	197	197
query54	303	296	271	271
query55	87	90	84	84
query56	319	339	314	314
query57	1216	1217	1139	1139
query58	283	269	270	269
query59	2531	2653	2535	2535
query60	341	338	329	329
query61	167	154	155	154
query62	811	745	661	661
query63	231	194	201	194
query64	4414	1225	867	867
query65	4051	3971	3973	3971
query66	1096	438	349	349
query67	15385	15119	14888	14888
query68	5870	879	601	601
query69	486	322	289	289
query70	1337	1270	1262	1262
query71	471	341	324	324
query72	6065	5196	5089	5089
query73	656	573	361	361
query74	9109	9066	8946	8946
query75	3315	3331	2842	2842
query76	3355	1146	741	741
query77	511	388	323	323
query78	9566	9762	8842	8842
query79	2900	852	598	598
query80	1707	590	511	511
query81	582	255	232	232
query82	484	163	136	136
query83	366	270	252	252
query84	256	109	93	93
query85	961	495	444	444
query86	476	321	294	294
query87	3760	3679	3696	3679
query88	3893	2283	2266	2266
query89	404	323	304	304
query90	1953	221	227	221
query91	172	161	131	131
query92	82	74	66	66
query93	2664	976	635	635
query94	759	420	334	334
query95	406	328	316	316
query96	494	580	287	287
query97	2934	2973	2854	2854
query98	244	219	207	207
query99	1341	1393	1290	1290
Total cold run time: 278095 ms
Total hot run time: 188181 ms

@doris-robot

doris-robot commented Nov 11, 2025

Copy link
Copy Markdown
ClickBench: Total hot run time: 27.39 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0b8ec407a8529b038c31ee5524ec104a8c4fd131, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.28	0.27	0.25
query6	1.17	0.65	0.65
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.60	0.52	0.51
query10	0.57	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.61
query14	1.02	0.99	1.00
query15	0.86	0.83	0.85
query16	0.41	0.39	0.39
query17	1.02	1.04	1.04
query18	0.22	0.21	0.20
query19	1.89	1.79	1.86
query20	0.01	0.01	0.01
query21	15.45	0.20	0.13
query22	5.06	0.08	0.05
query23	15.62	0.26	0.10
query24	3.08	0.59	0.28
query25	0.07	0.07	0.06
query26	0.15	0.13	0.12
query27	0.09	0.05	0.07
query28	3.76	1.13	0.95
query29	12.55	3.86	3.19
query30	0.29	0.15	0.12
query31	2.83	0.63	0.38
query32	3.26	0.57	0.48
query33	3.13	3.04	3.17
query34	15.83	5.20	4.58
query35	4.53	4.59	4.57
query36	0.68	0.50	0.49
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.01 s
Total hot run time: 27.39 s

@doris-robot

doris-robot commented Nov 11, 2025

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 20.00% (2/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.82% (18283/34611)
Line Coverage 38.20% (166246/435245)
Region Coverage 33.17% (129172/389449)
Branch Coverage 33.93% (55465/163491)

@hello-stephen

hello-stephen commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 90.00% (9/10) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.58% (24345/34011)
Line Coverage 58.05% (253069/435921)
Region Coverage 53.42% (211002/394960)
Branch Coverage 54.73% (90068/164566)

@yiguolei
yiguolei merged commit 14a2496 into apache:master Nov 12, 2025
12 checks passed
github-actions Bot pushed a commit that referenced this pull request Nov 12, 2025
@zhangstar333 Your Name
[Bug](udf) fix the _udf_close_workers thread pool not stop when exit (#…
dbdfa82 
…57918)

### What problem does this PR solve?
Problem Summary:
this pr introuced #55302
_udf_close_workers thread pool not stop when exit

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions Bot mentioned this pull request Nov 12, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 13, 2025
@github-actions @zhangstar333
branch-4.0: [Bug](udf) fix the _udf_close_workers thread pool not sto…
e77d523 
…p when exit #57918 (#57956)

Cherry-picked from #57918

Co-authored-by: zhangstar333 <[email protected]>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 13, 2025
@zhangstar333 @wyxxxcat
[Bug](udf) fix the _udf_close_workers thread pool not stop when exit (a…
ec4b34c 
…pache#57918)

### What problem does this PR solve?
Problem Summary:
this pr introuced apache#55302
_udf_close_workers thread pool not stop when exit

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@zhangstar333 @wyxxxcat
[Bug](udf) fix the _udf_close_workers thread pool not stop when exit (a…
d2444ff 
…pache#57918)

### What problem does this PR solve?
Problem Summary:
this pr introuced apache#55302
_udf_close_workers thread pool not stop when exit

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes
+1 more reviewer
@RoanHeNaN RoanHeNaN RoanHeNaN approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhangstar333 @Thearas @doris-robot @hello-stephen @yiguolei @RoanHeNaN