Skip to content

[fix](nereids)fix sync mv parse error if it contains sql KEYWORD #57052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Oct 21, 2025
Merged

[fix](nereids)fix sync mv parse error if it contains sql KEYWORD #57052

starocean999 merged 1 commit into from
Oct 21, 2025

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 16, 2025

What problem does this PR solve?

create table t1_dup (
            `install` int,
            ```install``` int,
            c1 int
        );
alter table t1_dup add rollup r1(```install```, `install`);

// the sync mv parser will throw exception because install is a keyword should be in backquote as `install`
select ```install```, `install` from t1_dup;

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 16, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 16, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/13) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

TPC-DS: Total hot run time: 189669 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fbfb46ded356838f9456fc2458b023c7b901b8ab, data reload: false

query1	1079	448	413	413
query2	6599	1712	1739	1712
query3	6763	228	230	228
query4	26360	24059	23075	23075
query5	4743	631	492	492
query6	345	240	218	218
query7	4653	499	296	296
query8	324	279	250	250
query9	8769	2559	2573	2559
query10	498	341	286	286
query11	15240	15720	15535	15535
query12	180	120	117	117
query13	2338	577	439	439
query14	11440	9584	9410	9410
query15	239	201	182	182
query16	7874	715	557	557
query17	2144	792	702	702
query18	2102	479	349	349
query19	216	203	177	177
query20	140	127	132	127
query21	216	137	129	129
query22	4512	4665	4511	4511
query23	35043	34049	33207	33207
query24	8457	2444	2379	2379
query25	567	498	430	430
query26	1231	274	153	153
query27	2737	503	355	355
query28	4341	2169	2165	2165
query29	793	653	493	493
query30	296	224	202	202
query31	962	813	735	735
query32	83	69	69	69
query33	581	372	321	321
query34	796	842	529	529
query35	812	824	743	743
query36	959	990	893	893
query37	132	105	89	89
query38	3523	3535	3407	3407
query39	1520	1428	1403	1403
query40	214	132	116	116
query41	59	58	57	57
query42	119	113	155	113
query43	491	501	458	458
query44	1325	824	814	814
query45	190	178	172	172
query46	859	1014	630	630
query47	1778	1788	1704	1704
query48	396	422	312	312
query49	764	531	427	427
query50	634	674	407	407
query51	3897	3929	3935	3929
query52	105	105	103	103
query53	238	271	193	193
query54	588	604	527	527
query55	86	83	84	83
query56	326	306	321	306
query57	1184	1200	1110	1110
query58	295	277	289	277
query59	2620	2707	2614	2614
query60	368	344	335	335
query61	162	154	151	151
query62	805	713	672	672
query63	236	200	194	194
query64	4521	1248	945	945
query65	4071	3984	3967	3967
query66	1112	490	331	331
query67	15754	15152	14982	14982
query68	9622	933	589	589
query69	493	329	289	289
query70	1361	1274	1199	1199
query71	494	344	310	310
query72	5855	4908	4809	4809
query73	711	585	356	356
query74	8832	9158	8967	8967
query75	4495	3333	2894	2894
query76	4124	1188	770	770
query77	1015	407	312	312
query78	9577	9731	8819	8819
query79	3048	843	587	587
query80	684	568	486	486
query81	487	263	222	222
query82	265	171	143	143
query83	292	270	251	251
query84	299	118	96	96
query85	919	462	426	426
query86	340	310	290	290
query87	3758	3778	3650	3650
query88	2835	2268	2213	2213
query89	443	325	307	307
query90	2153	213	208	208
query91	159	158	133	133
query92	87	147	69	69
query93	2210	969	648	648
query94	701	451	340	340
query95	403	306	318	306
query96	488	589	278	278
query97	2937	2982	2869	2869
query98	252	215	212	212
query99	1410	1437	1355	1355
Total cold run time: 283553 ms
Total hot run time: 189669 ms

@doris-robot
Copy link

doris-robot commented Oct 16, 2025

ClickBench: Total hot run time: 29.85 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fbfb46ded356838f9456fc2458b023c7b901b8ab, data reload: false

query1	0.06	0.04	0.04
query2	0.09	0.05	0.06
query3	0.26	0.10	0.08
query4	1.61	0.11	0.12
query5	0.28	0.26	0.26
query6	1.18	0.65	0.65
query7	0.03	0.02	0.02
query8	0.06	0.05	0.04
query9	0.62	0.52	0.53
query10	0.56	0.58	0.57
query11	0.16	0.11	0.12
query12	0.19	0.12	0.13
query13	0.63	0.61	0.61
query14	1.03	1.00	1.03
query15	0.88	0.84	0.87
query16	0.41	0.40	0.39
query17	1.04	1.04	1.05
query18	0.21	0.21	0.20
query19	1.89	1.85	1.84
query20	0.02	0.01	0.01
query21	15.49	0.93	0.58
query22	0.76	1.15	0.63
query23	15.03	1.38	0.64
query24	7.18	1.13	0.33
query25	0.30	0.15	0.08
query26	0.67	0.17	0.13
query27	0.06	0.06	0.05
query28	9.44	1.40	0.92
query29	12.58	3.88	3.22
query30	0.28	0.14	0.12
query31	2.83	0.59	0.40
query32	3.24	0.56	0.48
query33	3.14	3.14	3.17
query34	16.16	5.46	4.86
query35	4.93	4.89	4.89
query36	0.70	0.50	0.50
query37	0.10	0.07	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.16
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 104.56 s
Total hot run time: 29.85 s

@starocean999 starocean999 marked this pull request as ready for review October 17, 2025 06:14
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 322546c into apache:master Oct 21, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 21, 2025
@starocean999
[fix](nereids)fix sync mv parse error if it contains sql KEYWORD (#57052
b1336e4 
)

```
create table t1_dup (
            `install` int,
            ```install``` int,
            c1 int
        );
alter table t1_dup add rollup r1(```install```, `install`);

// the sync mv parser will throw exception because install is a keyword should be in backquote as `install`
select ```install```, `install` from t1_dup; 
```
@github-actions github-actions bot mentioned this pull request Oct 21, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 22, 2025
@github-actions @starocean999
branch-4.0: [fix](nereids)fix sync mv parse error if it contains sql …
3fb46e5 
…KEYWORD #57052 (#57190)

Cherry-picked from #57052

Co-authored-by: starocean999 <[email protected]>
@yiguolei yiguolei mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starocean999 @hello-stephen @doris-robot @englefly @morrySnow @yiguolei