Skip to content

[feature](func) Support MID function #56446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 1 commit into from
Sep 28, 2025
Merged

[feature](func) Support MID function #56446

HappenLee merged 1 commit into from
Sep 28, 2025

Conversation

@linrrzqqq
Copy link
Contributor

@linrrzqqq linrrzqqq commented Sep 25, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #48203

Related PR: #xxx

Problem Summary:

Release note

An alias of functionSUBSTRING.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Sep 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 25, 2025

ClickBench: Total hot run time: 30.58 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0be9412afc94ba772ecdcd43b08115ec3353e992, data reload: false

query1	0.05	0.06	0.05
query2	0.09	0.06	0.06
query3	0.27	0.08	0.08
query4	1.61	0.12	0.12
query5	0.28	0.27	0.27
query6	1.18	0.66	0.65
query7	0.03	0.03	0.02
query8	0.06	0.05	0.05
query9	0.63	0.54	0.52
query10	0.59	0.57	0.57
query11	0.17	0.12	0.12
query12	0.15	0.12	0.12
query13	0.64	0.64	0.64
query14	1.03	1.03	1.02
query15	0.87	0.85	0.88
query16	0.42	0.39	0.40
query17	1.09	1.06	1.05
query18	0.22	0.20	0.21
query19	1.95	1.93	1.88
query20	0.01	0.02	0.02
query21	15.44	0.94	0.58
query22	0.79	1.15	0.64
query23	15.02	1.38	0.67
query24	7.15	0.82	0.83
query25	0.51	0.19	0.10
query26	0.61	0.15	0.14
query27	0.08	0.06	0.06
query28	10.03	1.37	0.96
query29	12.54	3.86	3.24
query30	0.28	0.14	0.11
query31	2.84	0.58	0.38
query32	3.27	0.58	0.49
query33	3.19	3.05	3.16
query34	16.28	5.49	4.83
query35	4.97	4.95	4.96
query36	0.69	0.52	0.50
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.16	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 105.59 s
Total hot run time: 30.58 s

zclllyybb
zclllyybb reviewed Sep 25, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不光是substr的别名，它支持多种格式输入：MID(str,pos), MID(str FROM pos), MID(str,pos,len), MID(str FROM pos FOR len)

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Sep 25, 2025

这个不光是substr的别名，它支持多种格式输入：MID(str,pos), MID(str FROM pos), MID(str,pos,len), MID(str FROM pos FOR len)

substr也支持这些输入格式

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.39% (17613/33616)
Line Coverage 37.62% (160020/425396)
Region Coverage 32.18% (122099/379413)
Branch Coverage 33.52% (53532/159710)

@linrrzqqq
Copy link
Contributor Author

linrrzqqq commented Sep 25, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.03% (18716/32820)
Line Coverage 42.28% (179365/424241)
Region Coverage 36.89% (141822/384444)
Branch Coverage 37.94% (60837/160359)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.14% (18753/32820)
Line Coverage 42.40% (179864/424241)
Region Coverage 37.03% (142342/384444)
Branch Coverage 38.08% (61063/160359)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.14% (18753/32820)
Line Coverage 42.40% (179864/424241)
Region Coverage 37.03% (142342/384444)
Branch Coverage 38.08% (61063/160359)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 25, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

zclllyybb
zclllyybb approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 243f0bb into apache:master Sep 28, 2025
31 of 32 checks passed
@linrrzqqq linrrzqqq deleted the mid branch September 28, 2025 08:27
github-actions bot pushed a commit that referenced this pull request Oct 12, 2025
@linrrzqqq
[feature](func) Support MID function (#56446)
8980265
@github-actions github-actions bot mentioned this pull request Oct 12, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 16, 2025
@github-actions @linrrzqqq
branch-4.0: [feature](func) Support MID function #56446 (#56875)
d3288cb 
Cherry-picked from #56446

Co-authored-by: linrrarity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Good First Issue] Support All SQL Functions in Other SQL System

7 participants

@linrrzqqq @Thearas @doris-robot @hello-stephen @HappenLee @zclllyybb @yiguolei