Skip to content

branch-3.1: [fix](fold constant) abs's return type should be argument type #56190 #56210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 19, 2025
Merged

branch-3.1: [fix](fold constant) abs's return type should be argument type #56190 #56210

morrySnow merged 1 commit into from
Sep 19, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2025

Cherry-picked from #56190

@github-actions github-actions bot requested a review from morrySnow as a code owner September 19, 2025 02:45
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 19, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

TPC-H: Total hot run time: 32810 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6086865251481f39db95a1af6dcf6ee943ae4c5b, data reload: false

------ Round 1 ----------------------------------
q1	17583	5520	5443	5443
q2	2033	400	286	286
q3	12487	1266	745	745
q4	10301	902	477	477
q5	8898	2394	2154	2154
q6	180	162	133	133
q7	900	746	606	606
q8	9327	1440	1174	1174
q9	5220	4942	4920	4920
q10	6788	2279	1829	1829
q11	469	286	267	267
q12	337	364	216	216
q13	17785	3612	3005	3005
q14	234	224	208	208
q15	523	457	467	457
q16	423	423	376	376
q17	597	878	384	384
q18	6901	6455	6394	6394
q19	1193	978	553	553
q20	327	337	210	210
q21	2804	2160	1995	1995
q22	1041	1045	978	978
Total cold run time: 106351 ms
Total hot run time: 32810 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5466	5461	5452	5452
q2	233	323	237	237
q3	2248	2643	2353	2353
q4	1369	1813	1428	1428
q5	4397	4975	5029	4975
q6	172	159	128	128
q7	2111	1955	1818	1818
q8	2665	2826	2713	2713
q9	7247	7218	7213	7213
q10	2994	3325	2714	2714
q11	570	526	499	499
q12	677	767	661	661
q13	3370	3775	3198	3198
q14	301	286	263	263
q15	531	476	466	466
q16	435	476	436	436
q17	1229	1726	1251	1251
q18	7634	7445	7312	7312
q19	791	879	1128	879
q20	2010	2038	1918	1918
q21	5392	4991	4678	4678
q22	1089	1048	968	968
Total cold run time: 52931 ms
Total hot run time: 51560 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

TPC-DS: Total hot run time: 193753 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6086865251481f39db95a1af6dcf6ee943ae4c5b, data reload: false

query1	988	416	400	400
query2	6212	1959	1848	1848
query3	8691	200	196	196
query4	33381	24167	23831	23831
query5	4399	592	454	454
query6	306	207	170	170
query7	4221	502	329	329
query8	298	228	227	227
query9	9585	2609	2606	2606
query10	525	334	260	260
query11	18425	15929	15248	15248
query12	160	106	108	106
query13	1555	549	423	423
query14	9418	7426	7309	7309
query15	232	194	182	182
query16	8018	714	533	533
query17	1549	794	598	598
query18	2156	430	343	343
query19	234	182	169	169
query20	129	138	120	120
query21	201	128	110	110
query22	4708	4782	4448	4448
query23	35338	34232	34415	34232
query24	7526	2765	2736	2736
query25	559	507	433	433
query26	1192	288	185	185
query27	2025	487	371	371
query28	5592	2271	2266	2266
query29	817	629	518	518
query30	245	188	168	168
query31	1032	914	823	823
query32	86	61	61	61
query33	494	370	302	302
query34	758	843	530	530
query35	798	849	735	735
query36	1018	1068	998	998
query37	111	101	70	70
query38	4051	4048	4016	4016
query39	1701	1461	1471	1461
query40	214	118	110	110
query41	52	51	47	47
query42	123	106	103	103
query43	507	530	496	496
query44	1411	858	835	835
query45	186	187	176	176
query46	899	1064	696	696
query47	1961	1994	1944	1944
query48	455	446	360	360
query49	800	498	397	397
query50	701	709	433	433
query51	7369	7421	7319	7319
query52	107	108	95	95
query53	233	268	204	204
query54	567	548	471	471
query55	80	79	83	79
query56	261	282	265	265
query57	1274	1251	1225	1225
query58	238	231	219	219
query59	3160	3305	3015	3015
query60	304	299	284	284
query61	115	110	124	110
query62	791	774	708	708
query63	238	199	195	195
query64	4656	1003	634	634
query65	3394	3377	3274	3274
query66	929	405	315	315
query67	16124	16096	15680	15680
query68	7722	839	549	549
query69	491	312	271	271
query70	1269	1147	1118	1118
query71	398	305	278	278
query72	5693	3768	3847	3768
query73	652	761	356	356
query74	10224	9267	9000	9000
query75	3214	3122	2689	2689
query76	3143	1165	763	763
query77	703	376	284	284
query78	10389	10496	9609	9609
query79	3220	893	618	618
query80	626	532	443	443
query81	510	253	222	222
query82	584	117	86	86
query83	160	160	144	144
query84	244	103	80	80
query85	802	385	302	302
query86	369	316	270	270
query87	4299	4329	4226	4226
query88	5066	2442	2420	2420
query89	404	321	308	308
query90	1812	192	193	192
query91	141	145	111	111
query92	69	55	53	53
query93	1600	913	569	569
query94	693	401	321	321
query95	346	283	275	275
query96	503	609	286	286
query97	3181	3291	3145	3145
query98	222	214	196	196
query99	1498	1422	1297	1297
Total cold run time: 296130 ms
Total hot run time: 193753 ms

@doris-robot
Copy link

doris-robot commented Sep 19, 2025

ClickBench: Total hot run time: 28.52 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6086865251481f39db95a1af6dcf6ee943ae4c5b, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.64	0.11	0.10
query5	0.50	0.52	0.50
query6	1.12	0.75	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.59	0.49	0.49
query10	0.55	0.55	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.77	0.81	0.78
query15	0.83	0.83	0.82
query16	0.38	0.38	0.38
query17	1.02	1.02	1.04
query18	0.22	0.21	0.22
query19	1.96	1.80	1.79
query20	0.02	0.01	0.01
query21	15.39	0.94	0.59
query22	0.75	0.79	0.68
query23	15.08	1.55	0.56
query24	3.34	0.70	1.18
query25	0.11	0.05	0.07
query26	0.40	0.17	0.14
query27	0.07	0.05	0.04
query28	13.68	1.07	0.42
query29	12.59	3.93	3.19
query30	0.26	0.09	0.07
query31	2.81	0.62	0.37
query32	3.24	0.54	0.48
query33	2.99	3.04	3.01
query34	16.47	5.17	4.56
query35	4.54	4.60	4.52
query36	0.62	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.72 s
Total hot run time: 28.52 s

@morrySnow morrySnow merged commit 7d3e601 into branch-3.1 Sep 19, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-56190-branch-3.1 branch September 19, 2025 07:26
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @doris-robot @morrySnow @dataroaring