[fix](http stream) http stream should throw exception if parse sql failed #55863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where HTTP stream failed to properly handle SQL parsing errors, resulting in confusing null pointer exceptions instead of meaningful error messages. The fix ensures that parsing failures are properly caught and rethrown with descriptive error messages.
- Improves error handling by properly propagating SQL parsing exceptions in HTTP stream
- Enhances error message clarity by including the original SQL statement in logs
- Adds test coverage for SQL parsing error scenarios
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| regression-test/suites/load_p0/http_stream/test_http_stream.groovy | Adds test case for invalid SQL to verify proper error handling |
| fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java | Improves error logging with original SQL statement context |
| fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java | Fixes control flow to properly propagate parsing exceptions and prevent null pointer errors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| LOG.warn("Analyze failed. {}", context.getQueryIdentifier(), e); | ||
| throw ((NereidsException) e).getException(); | ||
| } | ||
| throw e; |
There was a problem hiding this comment.
The removal of the specific exception handling for NereidsException breaks the original logic. The code should still throw the nested exception from NereidsException rather than the wrapper exception itself.
Suggested change
| throw e; | |
| if (e instanceof NereidsException && e.getCause() != null) { | |
| // Restore original logic: throw the nested cause of NereidsException | |
| if (e.getCause() instanceof Exception) { | |
| throw (Exception) e.getCause(); | |
| } else if (e.getCause() instanceof Error) { | |
| throw (Error) e.getCause(); | |
| } else { | |
| throw new RuntimeException(e.getCause()); | |
| } | |
| } else { | |
| throw e; | |
| } |
TPC-H: Total hot run time: 34529 ms |
TPC-DS: Total hot run time: 188435 ms |
ClickBench: Total hot run time: 30.2 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…iled (#55863) Problem Summary: if http stream parse sql failed, the exception is ignored and continue execute, then throw exception: ``` "Message": "[ANALYSIS_ERROR]TStatus: errCode = 2, detailMessage = exec sql error catch unknown result.java.lang.NullPointerException: Cannot invoke \"org.apache.doris.planner.Planner.getFragments()\" because \"planner\" is null" ```
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…iled (#55863) Problem Summary: if http stream parse sql failed, the exception is ignored and continue execute, then throw exception: ``` "Message": "[ANALYSIS_ERROR]TStatus: errCode = 2, detailMessage = exec sql error catch unknown result.java.lang.NullPointerException: Cannot invoke \"org.apache.doris.planner.Planner.getFragments()\" because \"planner\" is null" ```
dataroaring
pushed a commit
that referenced
this pull request
Sep 11, 2025
…parse sql failed #55863 (#55890) Cherry-picked from #55863 Co-authored-by: meiyi <[email protected]>
morrySnow
pushed a commit
that referenced
this pull request
Sep 12, 2025
…parse sql failed #55863 (#55891) Cherry-picked from #55863 Co-authored-by: meiyi <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
if http stream parse sql failed, the exception is ignored and continue execute, then throw exception:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)