Skip to content

[fix] remove useless const_cast and explain const_cast - #55719

Closed
wumeibanfa wants to merge 24 commits into
apache:masterfrom
wumeibanfa:remove_const_cast
Closed

wumeibanfa wants to merge 24 commits into
apache:masterfrom
wumeibanfa:remove_const_cast

Conversation

@wumeibanfa

@wumeibanfa wumeibanfa commented Sep 5, 2025 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

go through whole be/ and find all const_cast

Issue Number: #55057

Problem Summary:

  1. remove useless const_cast
  2. explain why using const_cast does not result in undefined behavior
  3. don't modify some const_cast
    (1) some code in DBUG_EXECUTE_IF or test file
    (2) underlying data structures, like cow, slice
    (3) const_cast<const T*>

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas

Thearas commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wumeibanfa
wumeibanfa marked this pull request as draft September 5, 2025 08:03
@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run beut

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run beut

@zclllyybb zclllyybb self-assigned this Sep 5, 2025
@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run beut

2 similar comments
@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run beut

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run beut

@zclllyybb zclllyybb linked an issue Sep 6, 2025 that may be closed by this pull request
2 of 3 tasks
@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run buildall

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 34974 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bb6f44eb8e25c0a78800c71e627abf7934f46413, data reload: false

------ Round 1 ----------------------------------
q1	17656	5198	5077	5077
q2	1992	362	213	213
q3	10244	1348	739	739
q4	10307	1062	524	524
q5	9313	2450	2388	2388
q6	211	168	135	135
q7	956	771	640	640
q8	9378	1407	1160	1160
q9	7302	5216	5182	5182
q10	6990	2416	1992	1992
q11	507	303	292	292
q12	403	369	228	228
q13	17769	3738	3068	3068
q14	241	236	211	211
q15	585	503	502	502
q16	1015	1010	946	946
q17	621	886	384	384
q18	7474	7213	7139	7139
q19	1089	955	573	573
q20	348	349	230	230
q21	4194	3253	2351	2351
q22	1079	1055	1000	1000
Total cold run time: 109674 ms
Total hot run time: 34974 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5171	5096	5252	5096
q2	248	329	224	224
q3	2238	2644	2309	2309
q4	1375	1786	1332	1332
q5	4253	4118	4196	4118
q6	210	171	126	126
q7	1891	1809	1696	1696
q8	2505	2511	2472	2472
q9	6930	6847	6876	6847
q10	2954	3176	2695	2695
q11	571	529	485	485
q12	679	715	605	605
q13	3312	3698	3045	3045
q14	273	295	267	267
q15	522	469	480	469
q16	1039	1065	1019	1019
q17	1118	1461	1364	1364
q18	7369	7042	7094	7042
q19	797	769	832	769
q20	1942	1959	1855	1855
q21	4819	4359	4271	4271
q22	1085	1091	1048	1048
Total cold run time: 51301 ms
Total hot run time: 49154 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 189365 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bb6f44eb8e25c0a78800c71e627abf7934f46413, data reload: false

query1	861	414	437	414
query2	2065	1702	1694	1694
query3	5007	222	223	222
query4	25641	23930	23354	23354
query5	950	626	542	542
query6	333	255	248	248
query7	4515	525	317	317
query8	295	283	263	263
query9	5563	2944	2900	2900
query10	520	379	303	303
query11	15705	15030	14749	14749
query12	173	123	123	123
query13	1337	569	449	449
query14	9972	9121	9118	9118
query15	196	201	173	173
query16	5345	707	508	508
query17	871	739	612	612
query18	1556	490	336	336
query19	202	202	169	169
query20	134	127	123	123
query21	215	139	117	117
query22	4179	4092	4160	4092
query23	34329	33077	33280	33077
query24	6984	2369	2401	2369
query25	517	525	455	455
query26	975	285	168	168
query27	2440	529	356	356
query28	4350	2280	2244	2244
query29	799	605	481	481
query30	288	228	200	200
query31	849	825	713	713
query32	92	88	83	83
query33	490	403	364	364
query34	828	859	518	518
query35	848	834	755	755
query36	977	1044	928	928
query37	130	116	93	93
query38	3439	3542	3508	3508
query39	1513	1476	1437	1437
query40	230	134	127	127
query41	64	64	64	64
query42	130	120	120	120
query43	487	513	469	469
query44	1367	877	874	874
query45	183	182	175	175
query46	861	1040	666	666
query47	1809	1862	1757	1757
query48	406	434	326	326
query49	701	512	414	414
query50	646	701	398	398
query51	3930	3949	3880	3880
query52	126	121	112	112
query53	258	260	194	194
query54	625	626	551	551
query55	99	93	92	92
query56	346	351	323	323
query57	1181	1220	1127	1127
query58	296	291	282	282
query59	2565	2573	2544	2544
query60	376	354	359	354
query61	165	162	162	162
query62	816	746	678	678
query63	248	207	200	200
query64	3304	1280	958	958
query65	4073	3992	3970	3970
query66	836	432	361	361
query67	15652	15393	15119	15119
query68	9910	935	577	577
query69	506	325	301	301
query70	1408	1303	1330	1303
query71	603	347	325	325
query72	5558	4940	4866	4866
query73	611	569	365	365
query74	8945	8966	8978	8966
query75	4230	3237	2708	2708
query76	3712	1185	734	734
query77	798	409	343	343
query78	9618	9632	8839	8839
query79	3147	849	573	573
query80	733	583	524	524
query81	486	257	228	228
query82	427	163	132	132
query83	285	273	251	251
query84	299	112	97	97
query85	867	461	506	461
query86	344	317	304	304
query87	3711	3724	3642	3642
query88	3132	2271	2251	2251
query89	428	337	299	299
query90	1915	231	234	231
query91	161	167	138	138
query92	91	79	71	71
query93	1926	993	637	637
query94	688	492	322	322
query95	394	337	332	332
query96	488	586	289	289
query97	2937	2960	2852	2852
query98	242	222	224	222
query99	1470	1440	1310	1310
Total cold run time: 257333 ms
Total hot run time: 189365 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bb6f44eb8e25c0a78800c71e627abf7934f46413, data reload: false

query1	0.05	0.04	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.11	0.12
query5	0.28	0.27	0.25
query6	1.16	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.05	0.04
query9	0.61	0.53	0.51
query10	0.58	0.57	0.57
query11	0.17	0.11	0.12
query12	0.15	0.13	0.12
query13	0.62	0.62	0.63
query14	1.02	1.04	1.04
query15	0.86	0.85	0.88
query16	0.41	0.40	0.40
query17	1.04	1.02	1.06
query18	0.21	0.20	0.22
query19	1.95	1.82	1.80
query20	0.02	0.01	0.01
query21	15.40	0.97	0.59
query22	0.76	1.10	0.76
query23	14.94	1.41	0.60
query24	6.80	0.80	0.48
query25	0.49	0.14	0.15
query26	0.66	0.16	0.14
query27	0.05	0.05	0.05
query28	10.19	0.93	0.43
query29	12.57	3.84	3.22
query30	0.29	0.13	0.11
query31	2.82	0.59	0.41
query32	3.25	0.56	0.47
query33	3.05	3.05	3.08
query34	16.10	5.44	4.89
query35	4.98	4.95	4.94
query36	0.71	0.50	0.49
query37	0.11	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.16	0.14
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.76 s
Total hot run time: 29.63 s

@wumeibanfa
wumeibanfa marked this pull request as ready for review September 8, 2025 01:59
@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 34855 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3692f974b5f5129fcab1ca9fd68e79e3e5d5d48e, data reload: false

------ Round 1 ----------------------------------
q1	17614	5144	5088	5088
q2	1985	324	214	214
q3	10273	1304	725	725
q4	10225	1053	549	549
q5	7548	2450	2359	2359
q6	198	171	140	140
q7	941	778	622	622
q8	9346	1343	1186	1186
q9	7090	5153	5182	5153
q10	6969	2367	2005	2005
q11	507	310	286	286
q12	376	391	232	232
q13	17773	3676	3025	3025
q14	239	253	208	208
q15	577	486	500	486
q16	1028	1006	964	964
q17	636	880	378	378
q18	8016	7249	7081	7081
q19	1121	967	584	584
q20	351	349	227	227
q21	4244	3190	2365	2365
q22	1078	1050	978	978
Total cold run time: 108135 ms
Total hot run time: 34855 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5154	5098	5107	5098
q2	252	332	226	226
q3	2232	2699	2270	2270
q4	1361	1798	1331	1331
q5	4405	4519	4580	4519
q6	221	167	130	130
q7	2125	1982	1903	1903
q8	2717	2687	2613	2613
q9	7473	7307	7548	7307
q10	3080	3387	2892	2892
q11	579	548	499	499
q12	667	767	614	614
q13	3590	4043	3489	3489
q14	295	308	279	279
q15	538	480	497	480
q16	1042	1102	1080	1080
q17	1239	1631	1394	1394
q18	7792	7737	7627	7627
q19	1020	892	902	892
q20	1998	2041	1934	1934
q21	4825	4393	4388	4388
q22	1106	1069	1001	1001
Total cold run time: 53711 ms
Total hot run time: 51966 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 189385 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3692f974b5f5129fcab1ca9fd68e79e3e5d5d48e, data reload: false

query1	1049	439	411	411
query2	6563	1716	1698	1698
query3	6764	226	228	226
query4	26212	23293	22797	22797
query5	4404	668	518	518
query6	331	238	259	238
query7	4669	510	296	296
query8	311	259	248	248
query9	8572	2950	2946	2946
query10	490	332	297	297
query11	15871	14997	14803	14803
query12	171	120	116	116
query13	1697	545	424	424
query14	10945	9348	9408	9348
query15	216	204	178	178
query16	7320	660	507	507
query17	1214	785	620	620
query18	2001	425	341	341
query19	210	199	177	177
query20	135	124	128	124
query21	213	132	118	118
query22	4188	4414	4138	4138
query23	33885	33107	33034	33034
query24	8128	2391	2434	2391
query25	614	590	470	470
query26	1239	314	176	176
query27	2695	524	365	365
query28	4423	2263	2253	2253
query29	816	598	519	519
query30	294	239	200	200
query31	934	850	732	732
query32	90	84	86	84
query33	576	404	404	404
query34	806	866	533	533
query35	834	820	758	758
query36	970	1015	918	918
query37	127	116	103	103
query38	3544	3559	3508	3508
query39	1501	1439	1423	1423
query40	230	136	130	130
query41	64	64	62	62
query42	133	118	124	118
query43	541	499	465	465
query44	1385	880	867	867
query45	189	184	170	170
query46	858	1025	654	654
query47	1734	1784	1721	1721
query48	397	421	321	321
query49	754	517	411	411
query50	671	683	420	420
query51	3849	3961	3983	3961
query52	116	113	109	109
query53	255	279	204	204
query54	638	634	587	587
query55	100	94	93	93
query56	365	347	331	331
query57	1182	1193	1119	1119
query58	294	285	276	276
query59	2610	2635	2546	2546
query60	364	359	358	358
query61	164	158	163	158
query62	841	727	660	660
query63	235	199	196	196
query64	4543	1189	896	896
query65	4057	3959	4008	3959
query66	1185	433	359	359
query67	15436	15264	15129	15129
query68	7984	962	593	593
query69	514	335	318	318
query70	1375	1341	1367	1341
query71	537	357	319	319
query72	5826	5067	5214	5067
query73	687	650	372	372
query74	8910	9240	8596	8596
query75	3307	3285	2757	2757
query76	3216	1216	803	803
query77	488	411	340	340
query78	9661	9864	8871	8871
query79	2018	840	583	583
query80	697	566	514	514
query81	512	269	232	232
query82	232	169	134	134
query83	274	279	261	261
query84	264	119	93	93
query85	877	476	439	439
query86	378	299	303	299
query87	3779	3799	3723	3723
query88	2846	2261	2228	2228
query89	387	334	302	302
query90	1811	222	225	222
query91	160	166	184	166
query92	80	75	74	74
query93	1147	1007	652	652
query94	656	420	327	327
query95	411	337	317	317
query96	481	601	273	273
query97	2924	2996	2903	2903
query98	245	220	224	220
query99	1332	1451	1326	1326
Total cold run time: 272228 ms
Total hot run time: 189385 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3692f974b5f5129fcab1ca9fd68e79e3e5d5d48e, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.06	0.06
query3	0.26	0.08	0.08
query4	1.60	0.12	0.11
query5	0.28	0.27	0.25
query6	1.18	0.66	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.05
query9	0.63	0.53	0.52
query10	0.59	0.58	0.57
query11	0.17	0.12	0.11
query12	0.15	0.12	0.13
query13	0.63	0.63	0.62
query14	1.03	1.04	1.04
query15	0.88	0.85	0.87
query16	0.41	0.39	0.40
query17	1.07	1.08	1.06
query18	0.22	0.23	0.20
query19	1.94	1.85	1.87
query20	0.02	0.01	0.01
query21	15.47	0.96	0.58
query22	0.77	1.20	0.64
query23	14.95	1.44	0.64
query24	7.15	1.30	0.52
query25	0.50	0.19	0.18
query26	0.62	0.16	0.14
query27	0.07	0.06	0.05
query28	9.63	0.94	0.44
query29	12.58	4.04	3.27
query30	0.28	0.12	0.11
query31	2.83	0.63	0.38
query32	3.24	0.58	0.47
query33	3.13	3.15	3.10
query34	15.73	5.52	4.85
query35	4.95	4.91	4.93
query36	0.70	0.50	0.51
query37	0.11	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.19	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.46 s
Total hot run time: 29.73 s

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4d07591a292c067d370e8e1c7bc91f6dc3d24471, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.06
query3	0.26	0.08	0.09
query4	1.60	0.12	0.11
query5	0.28	0.26	0.26
query6	1.19	0.65	0.63
query7	0.04	0.03	0.03
query8	0.05	0.05	0.05
query9	0.62	0.52	0.51
query10	0.58	0.58	0.57
query11	0.17	0.12	0.11
query12	0.18	0.12	0.12
query13	0.63	0.62	0.63
query14	1.05	1.04	1.06
query15	0.86	0.85	0.86
query16	0.40	0.41	0.40
query17	1.05	1.08	1.06
query18	0.23	0.20	0.20
query19	1.97	1.85	1.86
query20	0.02	0.01	0.01
query21	15.43	0.97	0.58
query22	0.78	1.35	0.84
query23	14.74	1.39	0.67
query24	6.99	1.04	1.02
query25	0.50	0.28	0.13
query26	0.54	0.15	0.12
query27	0.07	0.05	0.06
query28	10.00	0.87	0.44
query29	12.54	3.87	3.28
query30	0.27	0.13	0.11
query31	2.83	0.61	0.39
query32	3.25	0.58	0.49
query33	3.19	3.14	3.08
query34	16.07	5.48	4.81
query35	4.99	4.90	4.94
query36	0.69	0.51	0.50
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.03	0.04
Total cold run time: 104.77 s
Total hot run time: 30.39 s

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 57.51% (291/506) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.34% (17554/33536)
Line Coverage 37.46% (159004/424461)
Region Coverage 32.03% (121258/378585)
Branch Coverage 33.39% (53203/159358)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run compile

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.02% (382/496) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.06% (23296/32784)
Line Coverage 57.35% (242811/423414)
Region Coverage 52.71% (202170/383551)
Branch Coverage 54.37% (87018/160057)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.02% (382/496) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.07% (23298/32784)
Line Coverage 57.34% (242790/423398)
Region Coverage 52.69% (202103/383543)
Branch Coverage 54.36% (87008/160053)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run p0

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.53% (383/494) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.07% (23298/32784)
Line Coverage 57.34% (242790/423398)
Region Coverage 52.69% (202103/383543)
Branch Coverage 54.36% (87008/160053)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.53% (383/494) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.07% (23298/32784)
Line Coverage 57.35% (242809/423398)
Region Coverage 52.72% (202196/383543)
Branch Coverage 54.37% (87015/160053)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 1504 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ebc840fca95aee53de1cbb0d2e0f74a445a2e31d, data reload: false

------ Round 1 ----------------------------------
q1	17661	27	19	19
q2	2592	27	25	25
q3	10729	16	15	15
q4	11153	18	17	17
q5	8104	15	13	13
q6	233	14	13	13
q7	978	23	24	23
q8	9472	15	13	13
q9	7477	27	13	13
q10	7019	13	14	13
q11	727	25	21	21
q12	341	13	12	12
q13	18604	14	12	12
q14	262	13	11	11
q15	625	13	11	11
q16	1084	973	960	960
q17	566	14	12	12
q18	7634	14	12	12
q19	1140	12	12	12
q20	1993	380	247	247
q21	9241	21	20	20
q22	1077	12	10	10
Total cold run time: 118712 ms
Total hot run time: 1504 ms

----- Round 2, with runtime_filter_mode=off -----
q1	12	11	12	11
q2	20	20	20	20
q3	12	12	11	11
q4	13	12	10	10
q5	11	11	12	11
q6	11	11	10	10
q7	19	19	20	19
q8	11	11	12	11
q9	11	11	11	11
q10	11	11	11	11
q11	19	19	19	19
q12	10	10	10	10
q13	10	10	10	10
q14	11	12	11	11
q15	11	12	12	12
q16	1058	1097	1033	1033
q17	13	12	10	10
q18	10	10	10	10
q19	11	10	10	10
q20	1880	1984	1858	1858
q21	22	20	19	19
q22	11	9	9	9
Total cold run time: 3197 ms
Total hot run time: 3136 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 2808 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ebc840fca95aee53de1cbb0d2e0f74a445a2e31d, data reload: false

query1	1092	20	12	12
query2	7130	17	16	16
query3	7641	12	11	11
query4	26602	11	11	11
query5	4446	14	14	14
query6	376	13	11	11
query7	5435	11	11	11
query8	353	21	18	18
query9	9227	11	9	9
query10	726	11	9	9
query11	15808	11	10	10
query12	192	11	10	10
query13	1716	10	9	9
query14	10743	15	13	13
query15	213	10	10	10
query16	7171	11	10	10
query17	1528	11	11	11
query18	2802	11	11	11
query19	203	10	8	8
query20	135	11	9	9
query21	226	10	10	10
query22	4078	10	9	9
query23	33751	19	12	12
query24	9558	13	13	13
query25	722	10	10	10
query26	1047	10	9	9
query27	3403	10	9	9
query28	6362	9	9	9
query29	1219	10	8	8
query30	626	12	10	10
query31	1759	11	12	11
query32	120	12	11	11
query33	1313	12	11	11
query34	1697	834	544	544
query35	879	11	11	11
query36	986	11	9	9
query37	124	11	11	11
query38	3556	10	10	10
query39	1510	750	745	745
query40	229	10	10	10
query41	89	12	11	11
query42	152	12	11	11
query43	506	11	10	10
query44	1333	10	10	10
query45	200	11	11	11
query46	914	12	12	12
query47	1806	12	9	9
query48	411	11	11	11
query49	1154	11	10	10
query50	750	10	10	10
query51	3846	10	9	9
query52	133	10	9	9
query53	252	11	10	10
query54	730	10	9	9
query55	98	11	10	10
query56	358	11	11	11
query57	1225	10	9	9
query58	319	12	10	10
query59	2697	11	9	9
query60	386	10	9	9
query61	200	10	10	10
query62	849	11	9	9
query63	270	11	10	10
query64	4269	10	9	9
query65	4082	11	8	8
query66	1683	10	9	9
query67	16545	13	14	13
query68	3537	11	10	10
query69	551	54	9	9
query70	1404	9	10	9
query71	422	356	349	349
query72	6990	11	9	9
query73	540	9	9	9
query74	9339	11	9	9
query75	3439	9	8	8
query76	2599	10	9	9
query77	873	11	10	10
query78	9809	24	10	10
query79	1079	9	10	9
query80	640	10	14	10
query81	552	11	9	9
query82	232	12	9	9
query83	319	11	9	9
query84	313	11	9	9
query85	1209	11	10	10
query86	419	9	10	9
query87	3927	10	10	10
query88	2798	10	9	9
query89	384	10	9	9
query90	2031	9	9	9
query91	172	9	9	9
query92	109	10	10	10
query93	1080	10	10	10
query94	764	10	9	9
query95	517	9	9	9
query96	424	11	8	8
query97	3122	10	9	9
query98	236	229	220	220
query99	1438	12	9	9
Total cold run time: 283229 ms
Total hot run time: 2808 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 0.09 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ebc840fca95aee53de1cbb0d2e0f74a445a2e31d, data reload: false

query1	0.07	0.02	0.01
query2	0.11	0.01	0.01
query3	0.26	0.00	0.01
query4	1.75	0.01	0.01
query5	0.30	0.01	0.00
query6	1.65	0.00	0.00
query7	0.05	0.01	0.00
query8	0.07	0.00	0.00
query9	0.62	0.00	0.00
query10	0.61	0.01	0.01
query11	0.18	0.01	0.00
query12	0.16	0.00	0.01
query13	0.64	0.01	0.01
query14	1.06	0.01	0.00
query15	0.88	0.00	0.00
query16	0.42	0.01	0.01
query17	1.05	0.01	0.00
query18	0.22	0.00	0.01
query19	1.90	0.00	0.00
query20	0.02	0.00	0.00
query21	15.38	0.00	0.01
query22	5.81	0.00	0.00
query23	15.75	0.00	0.00
query24	1.28	0.01	0.01
query25	0.22	0.00	0.00
query26	0.16	0.01	0.01
query27	0.10	0.00	0.01
query28	1.08	0.01	0.00
query29	13.27	0.00	0.01
query30	0.30	0.01	0.01
query31	2.30	0.00	0.00
query32	5.95	0.00	0.00
query33	4.37	0.00	0.00
query34	7.49	0.00	0.00
query35	6.43	0.00	0.00
query36	0.71	0.01	0.00
query37	0.11	0.01	0.00
query38	0.07	0.00	0.00
query39	0.05	0.00	0.00
query40	0.21	0.00	0.00
query41	0.10	0.00	0.00
query42	0.06	0.00	0.00
query43	0.05	0.01	0.00
Total cold run time: 93.27 s
Total hot run time: 0.09 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 57.51% (291/506) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.37% (17605/33619)
Line Coverage 37.56% (159759/425295)
Region Coverage 32.07% (121580/379062)
Branch Coverage 33.45% (53388/159611)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.56% (387/499) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.10% (23360/32857)
Line Coverage 57.39% (243551/424404)
Region Coverage 52.79% (202855/384237)
Branch Coverage 54.42% (87266/160348)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 1518 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 89d174f78b4d813e2edaaa5189177a9ab1144c4d, data reload: false

------ Round 1 ----------------------------------
q1	7156	35	19	19
q2	811	30	26	26
q3	966	16	14	14
q4	955	16	15	15
q5	2297	16	16	16
q6	226	14	13	13
q7	942	24	21	21
q8	1196	15	13	13
q9	11713	19	12	12
q10	7136	15	13	13
q11	450	22	21	21
q12	336	17	14	14
q13	17628	12	11	11
q14	252	13	12	12
q15	605	13	14	13
q16	1003	984	959	959
q17	563	12	11	11
q18	8071	12	11	11
q19	1044	12	11	11
q20	350	377	259	259
q21	3829	22	22	22
q22	1087	12	12	12
Total cold run time: 68616 ms
Total hot run time: 1518 ms

----- Round 2, with runtime_filter_mode=off -----
q1	11	11	11	11
q2	20	19	20	19
q3	11	12	11	11
q4	14	11	10	10
q5	11	12	12	12
q6	11	12	11	11
q7	19	18	19	18
q8	10	10	10	10
q9	10	10	14	10
q10	11	10	10	10
q11	19	19	20	19
q12	11	10	10	10
q13	10	10	10	10
q14	11	11	11	11
q15	10	10	10	10
q16	1066	1104	1036	1036
q17	13	11	11	11
q18	11	10	10	10
q19	11	10	10	10
q20	1856	1985	1836	1836
q21	22	19	19	19
q22	11	10	10	10
Total cold run time: 3179 ms
Total hot run time: 3114 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 2810 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 89d174f78b4d813e2edaaa5189177a9ab1144c4d, data reload: false

query1	1058	18	11	11
query2	7155	18	16	16
query3	7630	12	11	11
query4	27116	12	12	12
query5	4473	12	11	11
query6	376	11	10	10
query7	5444	12	12	12
query8	400	17	18	17
query9	9214	11	10	10
query10	720	12	10	10
query11	16354	12	12	12
query12	184	12	11	11
query13	1729	12	11	11
query14	11767	14	14	14
query15	389	11	11	11
query16	7534	12	11	11
query17	2163	11	11	11
query18	2936	12	11	11
query19	250	11	9	9
query20	143	11	10	10
query21	234	13	11	11
query22	4236	11	10	10
query23	33615	19	14	14
query24	10833	14	13	13
query25	774	10	10	10
query26	1815	11	10	10
query27	3407	11	9	9
query28	6263	11	10	10
query29	1777	11	10	10
query30	674	12	10	10
query31	1720	14	12	12
query32	123	13	12	12
query33	1325	10	9	9
query34	1640	831	535	535
query35	1037	12	10	10
query36	1000	10	9	9
query37	257	10	10	10
query38	3669	10	9	9
query39	1526	721	759	721
query40	324	12	11	11
query41	89	12	11	11
query42	167	11	12	11
query43	517	11	10	10
query44	1402	11	10	10
query45	379	12	11	11
query46	1170	11	10	10
query47	1805	10	9	9
query48	413	10	56	10
query49	1298	9	9	9
query50	783	10	9	9
query51	3924	10	10	10
query52	131	11	10	10
query53	247	12	11	11
query54	780	10	8	8
query55	98	10	9	9
query56	352	10	10	10
query57	1213	10	9	9
query58	354	10	9	9
query59	2640	9	9	9
query60	370	10	9	9
query61	178	10	9	9
query62	841	9	9	9
query63	275	12	13	12
query64	5495	10	9	9
query65	4296	14	13	13
query66	1853	14	12	12
query67	17094	37	10	10
query68	3628	10	10	10
query69	510	10	33	10
query70	1418	9	10	9
query71	453	349	347	347
query72	6754	10	10	10
query73	556	12	12	12
query74	10491	11	10	10
query75	3495	10	9	9
query76	3434	11	11	11
query77	913	14	11	11
query78	9756	22	11	11
query79	1118	10	11	10
query80	702	11	11	11
query81	904	9	8	8
query82	293	10	9	9
query83	315	10	9	9
query84	272	9	9	9
query85	1713	10	9	9
query86	564	9	10	9
query87	3978	10	9	9
query88	2889	12	10	10
query89	421	11	8	8
query90	2148	9	10	9
query91	196	11	9	9
query92	191	11	9	9
query93	1294	9	8	8
query94	1152	9	10	9
query95	684	10	8	8
query96	446	9	9	9
query97	3130	8	7	7
query98	248	244	235	235
query99	1559	12	12	12
Total cold run time: 297073 ms
Total hot run time: 2810 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 0.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 89d174f78b4d813e2edaaa5189177a9ab1144c4d, data reload: false

query1	0.06	0.01	0.01
query2	0.11	0.01	0.00
query3	0.27	0.01	0.01
query4	1.75	0.00	0.00
query5	0.30	0.01	0.00
query6	1.66	0.00	0.01
query7	0.05	0.01	0.00
query8	0.06	0.00	0.00
query9	0.61	0.00	0.00
query10	0.60	0.00	0.00
query11	0.18	0.00	0.00
query12	0.17	0.00	0.00
query13	0.65	0.00	0.00
query14	1.07	0.00	0.00
query15	0.92	0.00	0.00
query16	0.41	0.01	0.00
query17	1.05	0.01	0.00
query18	0.23	0.00	0.00
query19	1.91	0.01	0.01
query20	0.02	0.00	0.00
query21	15.36	0.01	0.00
query22	6.04	0.00	0.00
query23	16.41	0.00	0.01
query24	1.48	0.00	0.00
query25	0.23	0.00	0.00
query26	0.14	0.01	0.01
query27	0.12	0.01	0.00
query28	1.25	0.00	0.00
query29	13.27	0.01	0.00
query30	0.30	0.00	0.00
query31	2.18	0.00	0.00
query32	5.86	0.00	0.00
query33	4.37	0.01	0.00
query34	7.48	0.00	0.00
query35	6.20	0.01	0.00
query36	0.71	0.00	0.00
query37	0.12	0.00	0.00
query38	0.08	0.00	0.00
query39	0.05	0.00	0.01
query40	0.19	0.01	0.00
query41	0.10	0.00	0.00
query42	0.06	0.00	0.01
query43	0.05	0.00	0.01
Total cold run time: 94.13 s
Total hot run time: 0.04 s

@doris-robot

Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 57.51% (291/506) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.36% (17604/33622)
Line Coverage 37.57% (159710/425125)
Region Coverage 32.16% (121851/378879)
Branch Coverage 33.48% (53356/159366)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.15% (385/499) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.15% (23379/32860)
Line Coverage 57.49% (243900/424234)
Region Coverage 52.76% (202616/384052)
Branch Coverage 54.49% (87238/160103)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.15% (385/499) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.14% (23376/32860)
Line Coverage 57.49% (243879/424234)
Region Coverage 52.77% (202673/384052)
Branch Coverage 54.49% (87234/160103)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.15% (385/499) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.15% (23379/32860)
Line Coverage 57.49% (243901/424234)
Region Coverage 52.75% (202587/384052)
Branch Coverage 54.49% (87241/160103)

@wumeibanfa

Copy link
Copy Markdown
Contributor Author

run p0

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 77.15% (385/499) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.14% (23376/32860)
Line Coverage 57.48% (243849/424234)
Region Coverage 52.72% (202478/384052)
Branch Coverage 54.48% (87220/160103)

@wumeibanfa wumeibanfa closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove wrong usage of const_cast

8 participants